This repository was archived by the owner on Oct 4, 2022. It is now read-only.
Bugfix net binding destroying random entities#499
Open
CDufour909 wants to merge 3 commits intoaws:masterfrom
Open
Bugfix net binding destroying random entities#499CDufour909 wants to merge 3 commits intoaws:masterfrom
CDufour909 wants to merge 3 commits intoaws:masterfrom
Conversation
When a client is deleting netbound entities (for which he is not the authority), this leaves the NetBinding system with pointers to invalid entities in the m_boundEntities. Causing either crashes or deletion of random entities when the authority actually signals destruction of the netreplicated slice. I'm working around this by storing entity Ids rather than storing pointers.
The header file changing the m_boundEntities vector contents from Entity pointers to entity Ids
|
Thanks for the fix @CDufour909 ! We're looking over the change and will update this pull request as the status changes. |
Fixed bug where whole slice would get destroyed as soon as authority destroyed one of the slice's entities
Author
|
Hey @AMZN-alexpete, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client is deleting netbound entities (for which he is not the authority), this leaves the NetBinding system with pointers to invalid entities in the m_boundEntities. Causing either crashes or deletion of random entities when the authority actually signals destruction of the netreplicated slice.
To remedy this issue, I'm changingthe m_boundEntities vector contents from Entity pointers to Entity Ids.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.