This repository was archived by the owner on Oct 4, 2022. It is now read-only.
Only update PhysX editor colliders if transform has actually changed#515
Open
yuriy0 wants to merge 1 commit intoaws:masterfrom
Open
Only update PhysX editor colliders if transform has actually changed#515yuriy0 wants to merge 1 commit intoaws:masterfrom
yuriy0 wants to merge 1 commit intoaws:masterfrom
Conversation
The update is a relatively expensive operation which adds up quickly if the transform is updated to the same value on each tick
|
Hi @yuriy0 , Thanks for submitting this optimization, we'll evaluate it and update when complete. |
|
Hello yuriy0! We've reviewed your pull request and wanted to let you know we will be incorporating your proposed changes into our next version of the Lumberyard engine. Thank you kindly for contributing to Lumberyard! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the editor, PhysX colliders cannot be moved and are instead destroyed and re-created in the physical world every time the transform changes. This update is a relatively expensive operation which adds up quickly if the transform is updated very frequently e.g. every tick, and you have many colliders in your level.
This change adds a check in OnTransformChanged to see if the transform is actually different.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.