This repository was archived by the owner on Oct 4, 2022. It is now read-only.
Add auth header and upgrade SSL version to sslv23#541
Open
rustamserg wants to merge 1 commit intoaws:masterfrom
Open
Add auth header and upgrade SSL version to sslv23#541rustamserg wants to merge 1 commit intoaws:masterfrom
rustamserg wants to merge 1 commit intoaws:masterfrom
Conversation
|
@rustamserg Thank you for the PR, well look into your starting point and investigate implementing some of your suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
It is not possible to provide Authorization header to setup secure access into websocket gateway exposed to public internet.
Generic TLS version 1 is not accepted by modern nginx setup so changed it into sslv23.
Description of changes:
These changes are made to keep diff as small as possible to show places where gem's clients need modifications. It is not a good idea to take it as is but it is good starting point to understand what should be exposed via public gem bus.
So it would be awesome to have possibilities to add own headers and configure SSL/TLS versions for secure connections.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.