Skip to content

fix(payments): consolidated tutorial fixes (T00–T03, T06)#1738

Open
fahadfa-aws wants to merge 1 commit into
awslabs:mainfrom
fahadfa-aws:fix/payments-consolidated-tutorial-fixes
Open

fix(payments): consolidated tutorial fixes (T00–T03, T06)#1738
fahadfa-aws wants to merge 1 commit into
awslabs:mainfrom
fahadfa-aws:fix/payments-consolidated-tutorial-fixes

Conversation

@fahadfa-aws

@fahadfa-aws fahadfa-aws commented Jun 22, 2026

Copy link
Copy Markdown

Summary

  • T00 — Document Non-custodial Manage scope required for CDP API key
  • T01 — Remove duplicate flow diagram images, correct signing-error troubleshooting to point at WalletHub per-wallet grant, fix Strands Step 5c agent-reuse interrupt by instantiating a fresh agent
  • T02 — Pin agentcore CLI to 0.19+ (0.14 ships empty aws-targets.json), self-heal empty aws-targets.json in deploy script, correct runtime execution role documentation
  • T03 — Block on new wallet funding before checking balance
  • T06 — Cap memory polling loop at the documented 5-minute ceiling
  • Cross-tutorial — Align boto3 region with AWS_REGION from .env across deploy script, gateway agent, and shared utils

@github-actions

Copy link
Copy Markdown

Latest scan for commit: 2141e95 | Updated: 2026-06-22 17:12:18 UTC

Security Scan Results

Scan Metadata

  • Project: ASH
  • Scan executed: 2026-06-22T17:12:02+00:00
  • ASH version: 3.0.0

Summary

Scanner Results

The table below shows findings by scanner, with status based on severity thresholds and dependencies:

Column Explanations:

Severity Levels (S/C/H/M/L/I):

  • Suppressed (S): Security findings that have been explicitly suppressed/ignored and don't affect the scanner's pass/fail status
  • Critical (C): The most severe security vulnerabilities requiring immediate remediation (e.g., SQL injection, remote code execution)
  • High (H): Serious security vulnerabilities that should be addressed promptly (e.g., authentication bypasses, privilege escalation)
  • Medium (M): Moderate security risks that should be addressed in normal development cycles (e.g., weak encryption, input validation issues)
  • Low (L): Minor security concerns with limited impact (e.g., information disclosure, weak recommendations)
  • Info (I): Informational findings for awareness with minimal security risk (e.g., code quality suggestions, best practice recommendations)

Other Columns:

  • Time: Duration taken by each scanner to complete its analysis
  • Action: Total number of actionable findings at or above the configured severity threshold that require attention

Scanner Results:

  • PASSED: Scanner found no security issues at or above the configured severity threshold - code is clean for this scanner
  • FAILED: Scanner found security vulnerabilities at or above the threshold that require attention and remediation
  • MISSING: Scanner could not run because required dependencies/tools are not installed or available
  • SKIPPED: Scanner was intentionally disabled or excluded from this scan
  • ERROR: Scanner encountered an execution error and could not complete successfully

Severity Thresholds (Thresh Column):

  • CRITICAL: Only Critical severity findings cause scanner to fail
  • HIGH: High and Critical severity findings cause scanner to fail
  • MEDIUM (MED): Medium, High, and Critical severity findings cause scanner to fail
  • LOW: Low, Medium, High, and Critical severity findings cause scanner to fail
  • ALL: Any finding of any severity level causes scanner to fail

Threshold Source: Values in parentheses indicate where the threshold is configured:

  • (g) = global: Set in the global_settings section of ASH configuration
  • (c) = config: Set in the individual scanner configuration section
  • (s) = scanner: Default threshold built into the scanner itself

Statistics calculation:

  • All statistics are calculated from the final aggregated SARIF report
  • Suppressed findings are counted separately and do not contribute to actionable findings
  • Scanner status is determined by comparing actionable findings to the threshold
Scanner S C H M L I Time Action Result Thresh
bandit 0 0 0 0 13 0 1.1s 0 PASSED MED (g)
cdk-nag 0 0 0 0 0 0 6.5s 0 PASSED MED (g)
cfn-nag 0 0 0 0 0 0 4ms 0 PASSED MED (g)
checkov 0 0 0 0 0 0 5.0s 0 PASSED MED (g)
detect-secrets 0 0 0 0 0 0 1.0s 0 PASSED MED (g)
grype 0 0 0 0 0 0 48.1s 0 PASSED MED (g)
npm-audit 0 0 0 0 0 0 188ms 0 PASSED MED (g)
opengrep 0 0 0 0 0 0 <1ms 0 SKIPPED MED (g)
semgrep 0 0 0 0 0 0 <1ms 0 MISSING MED (g)
syft 0 0 0 0 0 0 2.2s 0 PASSED MED (g)

@fahadfa-aws fahadfa-aws force-pushed the fix/payments-consolidated-tutorial-fixes branch from 9de8310 to 9d7a338 Compare June 22, 2026 20:34
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions Bot added 03-AgentCore-identity 01-tutorials/03-AgentCore-identity 02-use-cases 02-use-cases 06-workshops labels Jun 22, 2026
- T00: Document Non-custodial Manage scope required for CDP API key
- T01: Remove duplicate flow diagrams, fix signing-error troubleshooting, fix Step 5c agent-reuse interrupt
- T02: Pin agentcore CLI to 0.19+, self-heal empty aws-targets.json, correct runtime role docs
- T03: Block on new wallet funding before checking balance
- T06: Cap memory polling at 5-minute ceiling
- Cross-tutorial: Align boto3 region with AWS_REGION from .env
@fahadfa-aws fahadfa-aws force-pushed the fix/payments-consolidated-tutorial-fixes branch from 9d7a338 to 4a153e5 Compare June 22, 2026 20:36
@github-actions github-actions Bot removed 03-AgentCore-identity 01-tutorials/03-AgentCore-identity 02-use-cases 02-use-cases 06-workshops labels Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant