fix: resolve gitleaks findings from v2 branch test fixtures - #678
fix: resolve gitleaks findings from v2 branch test fixtures#678scottschreckengaust wants to merge 2 commits into
Conversation
Add path allowlist for tests/harness/eval/shared-credential-scrubber.test.ts (TS port of the Python credential scrubber tests — contains intentional fake secrets for testing the scrubber). Add baseline entries for tests/unit/t243-doctor-bundle.test.ts findings (fake token=abcdef123456 test fixtures in the doctor bundle redaction tests, introduced in PR #576 on the v2 branch). All 7 findings are false positives — fake/test credentials used to verify that credential-scrubbing logic works correctly.
Python json.dump unescaped \u003c/\u003e/\u0026 to literal <>/& in the previous commit. Restore Go-style encoding to minimize diff noise.
harmjeff
left a comment
There was a problem hiding this comment.
Reviewed both changes:
.gitleaks.toml path allowlist — Adding shared-credential-scrubber.test.ts makes sense. It's the TypeScript port of the already-allowlisted Python test file (test_credential_scrubber.py), so this is consistent with existing policy. These are intentional fake secrets used to verify the scrubber works.
.gitleaks-baseline.json entries — The two token=abcdef123456 findings in t243-doctor-bundle.test.ts (lines 785, 849) are clearly test fixtures for the redaction logic introduced in PR #576. Low entropy (3.58), obvious placeholder pattern — correct to baseline these rather than allowlist the entire file.
Verification step is solid — gitleaks git --config=.gitleaks.toml --baseline-path=.gitleaks-baseline.json . with 511 commits and no leaks is a clean bill of health.
One minor note: the PR description mentions grype failures (38 HIGH vulns in uv.lock) as a separate PR — is that tracked somewhere? Might be worth opening an issue to ensure it doesn't slip.
Summary
Resolves the 7 gitleaks findings that have been failing the security-scanners workflow since June 19, 2026. All findings are false positives — fake/test credentials used in credential-scrubber test files.
Changes
.gitleaks.toml— path allowlist (Approach 1)Added
tests/harness/eval/shared-credential-scrubber.test.tsto the path allowlist. This is the TypeScript port of the already-allowlisted Pythontest_credential_scrubber.py. Covers 5 findings:eyJhbG...)ghp_1234567890abcdefghijklmnopqrstuv)a1b2c3d4e5f6...)Introduced by Arden Packeer in commit
b2e9ef29onfeature/js-evaluator-port(no PR, pushed directly)..gitleaks-baseline.json— baseline entries (Approach 2)Added 2 entries for
tests/unit/t243-doctor-bundle.test.ts:token=abcdef123456(redaction test fixture)token=abcdef123456(redaction test fixture in exported state file)Introduced by Leandro Damascena in commit
12c4d826via PR #576 (feat/doctor-bundle-575→v2), approved by apackeer.Verification
Note
This fixes gitleaks only. The grype failures (38 HIGH vulns in
scripts/aidlc-evaluator/uv.lock) require a separate dependency update PR.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.