Add IoT Metrics Support #809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into iot_metrics
This reverts commit 4bf6518.
sfod
reviewed
Feb 2, 2026
| * Enable AWS IoT metrics, if not set, default to enabled. | ||
| * | ||
| * @param enabled enable AWS IoT metrics to collect SDK usage data | ||
| * @return The ConnectPacket Object after setting the user property |
Contributor
There was a problem hiding this comment.
Should be @return this option object or something similar
| const Crt::Io::SocketOptions &socketOptions, | ||
| Crt::Io::TlsContext &&tlsContext); | ||
| Crt::Io::TlsContext &&tlsContext, | ||
| bool enableMetrics); |
Contributor
There was a problem hiding this comment.
Default value for a new argument should be specified here rather than in cpp. The same applies to other methods.
| m_connackTimeoutMs(0), m_ackTimeoutSec(0), m_allocator(allocator) | ||
| m_connackTimeoutMs(0), m_ackTimeoutSec(0), m_enableMetrics(true), m_allocator(allocator) | ||
| { | ||
| m_sdkMetrics = Mqtt::IoTDeviceSDKMetrics(); |
Contributor
There was a problem hiding this comment.
nit: m_sdkMetrics is already default constructed at this point, so this line can be safely removed.
|
|
||
| if (m_enableMetrics) | ||
| { | ||
| struct aws_mqtt_iot_sdk_metrics metrics; |
Contributor
There was a problem hiding this comment.
metrics should be zeroed. Otherwise we can get uninitialized fields here on adding meta data in aws-c-mqtt.
Comment on lines
+673
to
676
| /** Enable AWS IoT Metrics Collection. This is always set to true for now. */ | ||
| bool m_enableMetricsCollection; | ||
|
|
||
| Crt::String m_sdkName = "CPPv2"; | ||
| Crt::String m_sdkVersion = AWS_CRT_CPP_VERSION; |
Contributor
There was a problem hiding this comment.
Shouldn't we remove this? I think struct IoTDeviceSDKMetrics handles the metrics now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
IoTDeviceSDKMetricsand metrics related features , CRT is now appending AWS metrics by default.enableMetricsoption to allow user disable metrics.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.