Feature/reviewing-lexical-graph-documentation#124
Merged
iansrobinson merged 4 commits intoawslabs:mainfrom Feb 26, 2026
Merged
Conversation
…ioning in pyproject.toml
…teps to create and upload latest distribution copies and update notebook versions.
…ved readability and maintainability
- Remove streaming and dimensions fields from JSON examples (silently ignored) - Fix embed model type name: Bedrock -> BedrockEmbedding - Fix aws_region default: hardcoded us-east-1 -> default boto3 session region - Fix include_domain_labels env var: DEFAULT_INCLUDE_DOMAIN_LABELS -> INCLUDE_DOMAIN_LABELS - Add missing parameters: include_classification_in_entity_id, filename (logging) - Correct wildcard support description for set_advanced_logging_config
fbmz-improving
force-pushed
the
feature/reviewing-lexical-graph-documentation
branch
from
af884ca to
9e6e6b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation review and source code corrections for the
lexical-graphpackage.Source code fixes
to_indexing_configdefinition inlexical_graph_index.py(dead code silently overwriting the live definition)VectorStoreFactory.for_composite(for k, v in v.indexes→ renamed outer variable tovs)_aquerynow raisesNotImplementedErrorinstead of silently returningNoneprompt_provider_config.pyTenantIddocstring: max length was documented as 10, actual limit is 25Documentation fixes
configuration.md: corrected env var name (DEFAULT_INCLUDE_DOMAIN_LABELS→INCLUDE_DOMAIN_LABELS), removed invalid JSON fields (streaming,dimensions) from config examples, added missing parameters (include_classification_in_entity_id,filenamefor logging), correctedaws_regiondefault, fixedBedrockEmbeddingclass name, addedResilientClient/SSO sectionindexing.md: correctedchunk_overlapdefault (20 → 25), addedpreferred_topicstoExtractionConfigtable, added fullBuildConfigandBatchConfigparameter tablesmulti-tenancy.md: correctedTenantIdconstraints (1–10 chars → 1–25 chars, periods allowed), documented that extraction always writes under the default tenantquerying.md: addedcontext_formatoptions and per-factory defaults,verbosekwarg, async not implemented notice,get_stats/get_sources/delete_sourcesAPI referenceversioned-updates.md: added standaloneadd_versioning_infosignature blockfaq.md: added entry on the asyncio patch applied at import timeREADME.md: updated install URL, added connection string reference table, added S3 Vectors to dependencies, fixed context manager inconsistency in querying exampleresolves #115
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.