fix(crypto): validate JWK extractability - #1718
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
Related to #968.
Description of changes
Reject JWK imports when
extisfalsebut the caller requests an extractable key.The shared JWK import path previously did not enforce this WebCrypto constraint, allowing
importKey()orunwrapKey()to create an extractable key from material explicitly marked non-extractable. The shared path now rejects that contradiction with aDataErrorfor both operations while preserving successful import and unwrap whenextractableisfalse.This change is intentionally limited to the
ext/extractablecontradiction; validation ofalg,key_ops,use, and other JWK metadata remains out of scope.Relevant standards:
SubtleCrypto.importKey()Validation:
cargo test -p llrt_crypto --all-targets— 23 passedcrypto.subtleruntime suite — 18 passedcargo clippy -p llrt_crypto --all-targets -- -D warningscargo fmt --all -- --checktests/unit/crypto.subtle.test.tsgit diff --checkChecklist
checkjobBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.