Skip to content

Revert Commits That Disable Pytorch Tests For 1.7#390

Open
NihalHarish wants to merge 4 commits intomasterfrom
revert_changes
Open

Revert Commits That Disable Pytorch Tests For 1.7#390
NihalHarish wants to merge 4 commits intomasterfrom
revert_changes

Conversation

@NihalHarish
Copy link
Copy Markdown
Contributor

Description of changes:

  • Reverts two commits that had disabled Pytorch 1.7 ZCC tests

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NihalHarish NihalHarish requested a review from leleamol October 28, 2020 11:09
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 28, 2020

Codecov Report

Merging #390 (071b05d) into master (7c5c8c4) will decrease coverage by 1.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   66.25%   64.87%   -1.39%     
==========================================
  Files         173      163      -10     
  Lines       13275    12929     -346     
==========================================
- Hits         8796     8388     -408     
- Misses       4479     4541      +62     
Impacted Files Coverage Δ
smdebug/tensorflow/utils.py 63.03% <0.00%> (-23.23%) ⬇️
smdebug/tensorflow/callable_cache.py 60.86% <0.00%> (-21.74%) ⬇️
smdebug/tensorflow/singleton_utils.py 83.33% <0.00%> (-16.67%) ⬇️
smdebug/tensorflow/collection.py 84.53% <0.00%> (-11.35%) ⬇️
smdebug/tensorflow/keras.py 78.43% <0.00%> (-10.86%) ⬇️
smdebug/tensorflow/base_hook.py 74.63% <0.00%> (-3.68%) ⬇️
smdebug/tensorflow/session.py 88.46% <0.00%> (-3.37%) ⬇️
smdebug/core/collection_manager.py 90.24% <0.00%> (-2.44%) ⬇️
smdebug/core/collection.py 87.38% <0.00%> (-1.81%) ⬇️
smdebug/tensorflow/tensor_ref.py 87.09% <0.00%> (-1.62%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5c8c4...071b05d. Read the comment docs.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.25%. Comparing base (7c5c8c4) to head (071b05d).
⚠️ Report is 118 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   66.25%   66.25%   -0.01%     
==========================================
  Files         173      163      -10     
  Lines       13275    12929     -346     
==========================================
- Hits         8796     8566     -230     
+ Misses       4479     4363     -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants