revert(migrate): remove the vercel-to-aws plugin - #179
Merged
Conversation
Per product decision, remove the vercel-to-aws migration skill entirely. This is a forward-removal (not a git-revert): vercel landed via shared/cross-skill commits (awslabs#153/awslabs#157/awslabs#162/awslabs#155/awslabs#152/awslabs#176) that also carried heroku/gcp/sidebar work, so reverting those merge commits was not viable. Removed: - skills/vercel-to-aws/ (full skill, 57 files incl. its references/vendored/ copies) - fixtures/vercel-capture/ + fixtures/vercel-workshop/ (replay fixture sets) - Orphaned vercel report validator + its test + golden fixtures (lived at plugin level, not under the skill dir): scripts/validate-assessment-report.py, tests/test_validate_assessment_report.py, fixtures/assessment-report-{reference,stub}.html, fixtures/tier1-signals-reference.json (vercel prescan fixture, no consumers) - Deregistered from all 3 plugin manifests (.claude/.codex/.cursor-plugin): dropped vercel/next-js/nextjs/opennext keywords, the 'Vercel' mentions in descriptions, and the codex 'Assess my Vercel migration' example prompt - Stripped vercel from both READMEs (intro bullets, triggers, Vercel→AWS mapping table, trigger-table row, requirement bullet, DSL-architecture section: 'five skills'→'four', removed the resumability-ledger note) + fixtures/README registry line - Dropped vercel asserter entries from tools/run-asserters.py (10→6 asserters) - Stripped stale vercel cross-refs: heroku SKILL.md workshop-arch note, gcp schema-workshop-scenarios arch-defaults line, canonical workshop-invariants {SKILL_LABEL}/{INVENTORY} placeholders (shared:sync propagated to vendored copies) PRESERVED (heroku + gcp depend on these — awslabs#157's shared architecture): canonical skills/shared/workshop/workshop-invariants.md + skills/shared/estimate/pricing-mode.md and their heroku/gcp vendored copies. shared:check drops 4→3 trees cleanly (the sync tool auto-discovers consumers). Left legit non-skill refs: gcp's vercel.json detection signal, 'Vercel AI SDK' framework name, historical PR-context notes. Verified: shared:check OK (3 trees byte-identical), fixtures:assert 6/6, all validators green (heroku/gcp/agent-advisor), dprint + markdownlint clean, full mise run build green.
herosjourney
pushed a commit
to herosjourney/startups
that referenced
this pull request
Aug 13, 2026
…ter coverage Declare `_gates` as a validator-enforced sidebar frontmatter key (hold a backbone phase while unresolved). Cover heroku/agent-advisor/gcp in lint:frontmatter. Enforce check (c): when the gate target declares frontmatter it must be backbone. Carry `_gates: generate` on heroku's workshop (vercel-to-aws was removed on main in awslabs#179). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
herosjourney
pushed a commit
to herosjourney/startups
that referenced
this pull request
Aug 13, 2026
Resolves the one true conflict (mise.toml lint:frontmatter task: this branch added gcp-to-aws to the migrate-plugin invocation list, main added the whole advisor-plugin invocation list via awslabs#206's port — kept both). Since this branch predates the awslabs#206 advisor consolidation, propagated this PR's changes to the advisor plugin's copies so both plugins stay in parity, matching the pattern _gates already uses (canonical + vendored, migrate + advisor): - skills/shared/dsl/INTERPRETER.md, skills/shared/workshop/workshop-invariants.md (advisor's canonical copies): added the _gates row/semantics, ported 1:1 from the migrate canonical (only diff was the pre-existing migration-to-aws: -> aws-startup-advisor: prefix rename) - skills/heroku-to-aws/references/phases/workshop/workshop.md: added _gates: generate (advisor's heroku workshop lacked it; vercel-to-aws doesn't exist in either plugin, matching this PR's note that vercel was removed on main in awslabs#179) - tools/frontmatter-validator/{parse,types,check}.ts: ported the same _gates parsing/typing/structural-check additions (advisor's validator is a per-plugin copy, not vendored-shared, so it hadn't received them) - tests/tools/frontmatter-validator.test.ts: ported the 5 new _gates test cases at the same position (62 pass, matching migrate's count) - mise.toml: added gcp-to-aws to advisor's lint:frontmatter invocation list for parity (0 frontmatter files today in both gcp-to-aws copies, same guarded-for-rollout state the PR already established for migrate) Ran `node .../sync-vendored-shared.ts --write` for both plugins after resolving: migrate 0 files changed (already in sync), advisor 4 files updated (heroku/agent-advisor/gcp-to-aws vendored copies picking up the _gates addition from canonical). Verified: advisor tsc --noEmit clean; advisor frontmatter-validator test suite 62/62 pass; full `mise run build` green (0 task failures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per product decision, remove the vercel-to-aws migration skill entirely.
This is a forward-removal, not a
git revert. vercel-to-aws landed on main via shared/cross-skill merge commits (#153, #157, #162, #155, #152, #176) that also carried heroku/gcp/sidebar work — reverting those commits would rip out unrelated, shipped functionality. So this removes vercel going forward while preserving the shared infrastructure heroku + gcp now depend on.Removed
skills/vercel-to-aws/— the full skill (57 files, including itsreferences/vendored/copies)fixtures/vercel-capture/+fixtures/vercel-workshop/— replay fixture setsscripts/validate-assessment-report.py,tests/test_validate_assessment_report.py,fixtures/assessment-report-{reference,stub}.html,fixtures/tier1-signals-reference.json(vercel prescan fixture, no consumers).claude-plugin,.codex-plugin,.cursor-plugin): droppedvercel/vercel-to-aws/next-js/nextjs/opennextkeywords, the "Vercel" mentions in descriptions, and the codex "Assess my Vercel migration" example promptfixtures/READMEregistry linetools/run-asserters.py: dropped the 4 vercel asserter entries (10 → 6)SKILL.mdworkshop-arch note, gcpschema-workshop-scenariosarch-defaults line, and the canonicalworkshop-invariants.md{SKILL_LABEL}/{INVENTORY}placeholders (change made to canonical +shared:syncpropagated to vendored copies)Preserved (deliberately — the #157 shared architecture)
#157 extracted the workshop contract + estimate pricing-mode into canonical
skills/shared/files that heroku + gcp vendor and depend on. These are NOT vercel's and are untouched:skills/shared/workshop/workshop-invariants.mdskills/shared/estimate/pricing-mode.mdshared:checkdrops from 4 vendored trees to 3 cleanly — the sync tool auto-discovers consumers, so a removed skill simply drops out.Also left in place (legitimate, not vercel-skill references): gcp's
vercel.jsonapp-code detection signal, the "Vercel AI SDK" framework name in the llm2bedrock analyzer, and historical PR-context notes in fixture READMEs.Test plan
shared:checkOK — 3 vendored trees byte-identical (heroku, gcp, agent-advisor)fixtures:assert— 6/6 (2 golden, 4 smoke); no dangling vercel registry entrymise run buildgreen