Open
Conversation
awygle
reviewed
Jun 29, 2022
sequencer_server/src/record.rs
Outdated
| // No whitelist, match all. | ||
| // Length tag | ||
| writer.write_u16_le(message.len() as u16).await?; | ||
| writer.write_u64_le(message.len() as LengthTag).await?; |
Owner
There was a problem hiding this comment.
I'm guessing this is using tokio's WriteAsyncExt - is there something equivalent to https://docs.rs/byteorder/latest/byteorder/trait.WriteBytesExt.html#method.write_uint available? Would be nice to only have to change the LengthTag newtype if we change this in the future.
Collaborator
Author
There was a problem hiding this comment.
From what I can see there is no official Tokio support for it but a crate for this purpose has been published: https://docs.rs/tokio-byteorder/latest/tokio_byteorder/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exactly as described - Rkyv should now be able to deserialize messages read from the message bus because the length tag no longer breaks Rkyv's expected 64-bit alignment for a Sequencer message. All of the tests I've written are passing for sequencer_server.