Skip to content

XIVY-19091 multi-select Program widget#1583

Draft
ivy-rew wants to merge 3 commits into
masterfrom
program.select
Draft

XIVY-19091 multi-select Program widget#1583
ivy-rew wants to merge 3 commits into
masterfrom
program.select

Conversation

@ivy-rew

@ivy-rew ivy-rew commented Jun 30, 2026

Copy link
Copy Markdown
Member

adapt: https://github.com/axonivy/core/pull/13532

first copy-adaption of role-editor multi-select

  • adding special icon support
  • (not yet) with validation that the items exist ... can follow later

@ivy-rew ivy-rew force-pushed the program.select branch 3 times, most recently from 5c2b625 to 6a30866 Compare June 30, 2026 12:26
Comment on lines +403 to +411
name: 'whoami',
description: 'identifies the current user',
icon: '🪪️'
},
{
name: 'add',
description: 'calculation universe',
icon: 'https://imgcdn.stablediffusionweb.com/2024/12/15/3388743d-2e7a-4cd2-a17c-cba86a6573bd.jpg'
},

@ivy-rew ivy-rew Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an idea; the icon could be a dynamic value ... either an URI or an emoji, or SVG data

item-icon-variants

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think thats good. Maybe @ivy-lli has an option here. Also I think something might be missing in the CSS. Shouldn’t the items popup stretch to the full width of the combobox field? Isn’t that how it works in the role editor?

@@ -0,0 +1,122 @@
.ui-combobox-root {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vibe coded adaption of the role-editor; but here without tailwind.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance it looks good, but I think something might be missing. If the multiselect is intended to look like in the screenshot you shared above, the popup should probably stretch to the same width as the combobox input field.

@ivy-rew ivy-rew requested a review from ivy-edp June 30, 2026 13:57
{
name: 'websearch',
description: 'latest web search results',
icon: 'data:image/svg+xml;base64,<svg fill="none" viewBox="0 0 184 148" xmlns="http://www.w3.org/2000/svg">
  <path fill="#fff" d="M69.942 129.26H66.46l-6.338 6.517v-13.033h-2.678v22.228h2.678v-7.32l7.23 7.23.09.09h3.214v-.268l-8.124-8.034zm-17.14 11.873c-.982.982-2.41 1.518-4.017 1.518-2.767 0-5.534-1.696-5.534-5.624 0-3.303 2.32-5.624 5.534-5.624 1.428 0 2.767.536 3.839 1.518l.089.089 1.696-1.786-.09-.089c-1.606-1.517-3.48-2.232-5.623-2.232-4.91 0-8.213 3.303-8.213 8.124 0 5.624 4.106 8.123 8.213 8.123h.09c2.141 0 4.195-.803 5.623-2.321l.09-.089-1.786-1.785zm-18.122-3.481c0 2.856-1.963 4.999-4.73 5.088-2.946 0-4.732-1.785-4.732-4.82v-8.66H22.54v8.66c0 4.463 2.678 7.32 6.874 7.32h.09c2.052 0 3.927-.982 5.177-2.5l.089-.179.09 2.411h2.499V129.26H34.68zM8.347 122.655H.223v22.317h8.124c7.766 0 11.158-5.713 11.158-11.337 0-5.267-3.481-10.98-11.158-10.98zm8.39 10.89c0 4.285-2.588 8.57-8.301 8.57H3.08v-16.693h5.267c5.713 0 8.39 4.196 8.39 8.123zm138.277 1.697h6.874v5.177c-1.696 1.428-3.749 2.232-5.981 2.232-6.07 0-8.838-4.374-8.838-8.659 0-4.374 2.768-9.106 8.749-9.106 2.41 0 4.642.893 6.427 2.5l.089.089 1.607-1.874-.089-.09c-2.143-2.142-4.999-3.213-8.124-3.213-3.392 0-6.248 1.071-8.302 3.213-2.142 2.143-3.302 5.178-3.213 8.57 0 5.267 3.035 11.337 11.605 11.337h.178c3.214 0 6.249-1.339 8.391-3.749v-8.838h-9.462v2.411zm-73.735-12.587h-8.124v22.317h8.124c7.766 0 11.158-5.713 11.158-11.337 0-5.267-3.481-10.98-11.158-10.98zm8.39 10.89c0 4.285-2.588 8.57-8.301 8.57h-5.267v-16.693h5.267c5.624 0 8.302 4.196 8.302 8.123zm85.609-4.642c-4.731 0-8.123 3.482-8.123 8.213s3.392 8.124 8.123 8.124 8.213-3.393 8.213-8.124c0-4.82-3.392-8.213-8.213-8.213zm5.535 8.213c0 3.303-2.321 5.624-5.535 5.624-3.124 0-5.445-2.321-5.445-5.624 0-3.392 2.232-5.802 5.534-5.802 3.125.089 5.446 2.499 5.446 5.802zm-73.2.536c0 2.856-1.964 4.999-4.731 5.088-2.946 0-4.731-1.785-4.731-4.82v-8.66h-2.679v8.66c0 4.463 2.679 7.32 6.785 7.32h.089c2.053 0 3.928-.982 5.178-2.5l.089-.179.089 2.411h2.5V129.26h-2.678v8.392zm18.121 3.481c-.982.982-2.41 1.518-4.017 1.518-2.767 0-5.534-1.696-5.534-5.624 0-3.303 2.321-5.624 5.534-5.624 1.429 0 2.768.536 3.839 1.518l.089.089 1.696-1.786-.089-.089c-1.607-1.517-3.482-2.232-5.624-2.232-4.91 0-8.213 3.303-8.213 8.124 0 5.624 4.107 8.123 8.213 8.123h.089c2.143 0 4.196-.803 5.624-2.321l.089-.089-1.785-1.785zm17.14-11.873h-3.482l-6.338 6.517v-13.033h-2.678v22.228h2.678v-7.32l7.231 7.23.089.09h3.214v-.268l-8.123-8.034z"/>
  <path fill="#de5833" fill-rule="evenodd" d="M91.946 107.122c29.581 0 53.561-23.98 53.561-53.561S121.527 0 91.947 0C62.364 0 38.384 23.98 38.384 53.561s23.98 53.561 53.561 53.561z" clip-rule="evenodd"/>
  <path fill="#ddd" fill-rule="evenodd" d="M99.478 93.522c0-.418.103-.513-1.227-3.165-3.535-7.079-7.088-17.059-5.472-23.495.294-1.17-3.33-43.304-5.892-44.661-2.848-1.518-6.351-3.925-9.556-4.46-1.626-.26-3.758-.138-5.425.087-.296.04-.308.572-.025.668 1.094.37 2.423 1.014 3.206 1.988.148.184-.051.474-.287.482-.738.028-2.077.337-3.844 1.838-.204.173-.035.495.228.443 3.797-.75 7.674-.38 9.96 1.696.148.135.07.377-.123.43C61.19 30.76 65.117 48.01 70.396 69.177c4.654 18.666 6.435 24.81 7.012 26.727a.72.72 0 0 0 .424.469c6.85 2.697 21.646 2.805 21.646-1.805z" clip-rule="evenodd"/>
  <path fill="#fff" d="M102.198 97.498c-2.406.941-7.114 1.36-9.833 1.36-3.988 0-9.73-.628-11.821-1.57-1.293-3.976-5.16-16.303-8.978-31.956l-.374-1.53-.003-.012c-4.54-18.542-8.248-33.687 12.074-38.445.185-.043.276-.265.153-.411-2.331-2.766-6.7-3.673-12.222-1.768-.227.079-.424-.15-.283-.344 1.083-1.493 3.2-2.64 4.244-3.144.216-.104.203-.42-.025-.491a23.299 23.299 0 0 0-3.156-.753c-.31-.05-.338-.58-.027-.623 7.83-1.053 16.006 1.298 20.109 6.466a.272.272 0 0 0 .155.096c15.024 3.226 16.1 26.977 14.369 28.059-.341.213-1.434.09-2.877-.07-5.846-.655-17.422-1.95-7.868 15.856.094.176-.03.409-.228.44-5.388.837 1.517 17.719 6.591 28.84z"/>
  <path fill="#3ca82b" d="M108.919 75.904c-1.144-.53-5.542 2.624-8.461 5.045-.61-.863-1.76-1.49-4.355-1.04-2.27.396-3.524.943-4.084 1.887-3.584-1.359-9.614-3.456-11.07-1.43-1.593 2.214.397 12.687 2.512 14.047 1.104.71 6.386-2.685 9.144-5.026.445.627 1.162.986 2.634.952 2.228-.052 5.841-.57 6.401-1.608.034-.063.064-.137.089-.222 2.835 1.06 7.824 2.18 8.939 2.014 2.905-.437-.405-13.996-1.749-14.619z"/>
  <path fill="#4cba3c" d="M100.725 81.26c.121.214.217.44.3.67.404 1.13 1.062 4.726.564 5.614-.498.888-3.732 1.317-5.727 1.351s-2.444-.695-2.848-1.825c-.324-.904-.483-3.03-.479-4.247-.082-1.806.578-2.44 3.627-2.934 2.257-.365 3.45.06 4.138.786 3.204-2.39 8.549-5.765 9.07-5.148 2.6 3.075 2.928 10.394 2.365 13.34-.184.962-8.791-.955-8.791-1.993 0-4.311-1.119-5.494-2.219-5.615zM81.87 79.913c.706-1.116 6.422.272 9.56 1.668 0 0-.644 2.922.382 6.364.3 1.007-7.22 5.488-8.201 4.717-1.134-.891-3.222-10.404-1.74-12.75z"/>
  <path fill="#fc3" fill-rule="evenodd" d="M84.64 57.249c.462-2.012 2.617-5.802 10.31-5.71 3.89-.016 8.722-.001 11.926-.365a42.885 42.885 0 0 0 10.65-2.59c3.331-1.27 4.513-.988 4.927-.227.456.835-.081 2.278-1.245 3.606-2.223 2.536-6.219 4.502-13.277 5.085-7.058.583-11.734-1.31-13.746 1.772-.868 1.33-.197 4.463 6.628 5.45 9.223 1.33 16.798-1.604 17.734.168s-4.455 5.38-13.693 5.455c-9.239.076-15.009-3.234-17.055-4.88-2.597-2.087-3.758-5.132-3.16-7.764z" clip-rule="evenodd"/>
  <g fill="#14307e" opacity=".8">
    <path d="M96.404 35.256c.516-.844 1.658-1.495 3.528-1.495s2.75.744 3.359 1.573c.124.17-.064.368-.256.285l-.14-.061c-.684-.299-1.524-.666-2.963-.686-1.538-.022-2.508.363-3.12.695-.205.112-.53-.111-.408-.311zm-21.053 1.079c1.816-.759 3.243-.66 4.252-.422.213.05.36-.178.19-.315-.783-.632-2.535-1.416-4.821-.564-2.039.76-3 2.34-3.006 3.379-.001.245.503.265.633.058.352-.56.937-1.377 2.752-2.136z"/>
    <path fill-rule="evenodd" d="M101.521 46.799c-1.606 0-2.908-1.299-2.908-2.897s1.302-2.897 2.908-2.897c1.605 0 2.907 1.299 2.907 2.897s-1.302 2.897-2.907 2.897zm2.047-3.857a.752.752 0 0 0-1.505 0 .752.752 0 0 0 1.505 0zm-21.31 2.965a3.383 3.383 0 0 1-3.389 3.378c-1.87 0-3.389-1.513-3.389-3.378s1.52-3.379 3.389-3.379a3.385 3.385 0 0 1 3.389 3.379zm-.999-1.12a.878.878 0 0 0-1.755 0 .876.876 0 0 0 1.755 0z" clip-rule="evenodd"/>
  </g>
  <path fill="#fff" fill-rule="evenodd" d="M91.946 98.544c24.843 0 44.983-20.14 44.983-44.983 0-24.843-20.14-44.983-44.983-44.983-24.843 0-44.983 20.14-44.983 44.983 0 24.843 20.14 44.983 44.983 44.983zm0 4.184c27.154 0 49.167-22.013 49.167-49.167S119.1 4.394 91.946 4.394 42.78 26.407 42.78 53.56s22.013 49.167 49.167 49.167z" clip-rule="evenodd"/>
</svg>
'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duckduckgo svg 🦆

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new multi-select widget for the Program configuration UI (aligned with the referenced core change), including protocol support for a MULTI_SELECT widget type and a UI implementation with chip-based selection and icon rendering.

Changes:

  • Extend inscription protocol widget model to include MULTI_SELECT and SelectableItem.
  • Add MultiSelectWidget (Base UI Combobox-based) + styling, and render it from ConfigurationPart.
  • Add @base-ui/react dependency and update integration mock data to include a multi-select example.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pnpm-lock.yaml Locks new dependencies introduced for Base UI Combobox usage.
packages/inscription-view/src/components/widgets/multi-select/MultiSelectWidget.tsx New multi-select combobox/chips widget with icon rendering.
packages/inscription-view/src/components/widgets/multi-select/MultiSelectWidget.css Styling for the new multi-select widget.
packages/inscription-view/src/components/parts/program/configuration/ConfigurationPart.tsx Renders the new MULTI_SELECT widget type in Program configuration.
packages/inscription-view/package.json Adds @base-ui/react dependency.
packages/inscription-protocol/src/data/inscription.ts Adds protocol types for MULTI_SELECT and selectable items.
integration/inscription/src/mock/meta-mock.ts Adds mock data demonstrating the new multi-select widget.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +30 to +46
export function MultiSelectWidget({ value, onChange, items, configKey }: MultiSelectWidgetProps) {
const containerRef = useRef<HTMLDivElement | null>(null);
const { inputProps } = useField();
const readonly = useReadonly();

const itemIds = useMemo(() => items.map(item => item.name), [items]);

const mergedItems = useMemo(() => {
const merged = [...items];
const mergedIds = merged.map(item => item.name);
value.filter(v => !mergedIds.includes(v)).forEach(v => merged.push({ name: v, description: '', icon: '' }));
return merged;
}, [items, value]);

return (
<Combobox.Root items={itemIds} multiple value={value} onValueChange={onChange} disabled={readonly}>
<Combobox.Chips className='ui-combobox-root' ref={containerRef}>
Comment thread integration/inscription/src/mock/meta-mock.ts
Comment thread packages/inscription-protocol/src/data/inscription.ts

@ivy-edp ivy-edp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, two comments, otherwise I think it looks good. The next step would be to move this into ui-components so it can be reused everywhere.

/>
);
}
if (isMultiSelect(widget)) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also be able to work with a type guard here, so the cast "as MutliSelect" should nolonger be needed. I think maybe something like this (see form editor form-data.ts e.g. "isTable"):

function isMultiSelect(widget: Widget): widget is MultiSelect {
  return widget.widgetType === 'MULTI_SELECT';
}
``

Comment on lines +403 to +411
name: 'whoami',
description: 'identifies the current user',
icon: '🪪️'
},
{
name: 'add',
description: 'calculation universe',
icon: 'https://imgcdn.stablediffusionweb.com/2024/12/15/3388743d-2e7a-4cd2-a17c-cba86a6573bd.jpg'
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think thats good. Maybe @ivy-lli has an option here. Also I think something might be missing in the CSS. Shouldn’t the items popup stretch to the full width of the combobox field? Isn’t that how it works in the role editor?

@@ -0,0 +1,122 @@
.ui-combobox-root {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance it looks good, but I think something might be missing. If the multiselect is intended to look like in the screenshot you shared above, the popup should probably stretch to the same width as the combobox input field.

@ivy-rew

ivy-rew commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

I keep it open: if anyone feels like completing this, feel free to complete this while I'm on vacation 🌴

To be discussed:

  • icon: I love the flexibility but maybe we introduce a security issue. My favorite would be to detect emojis somehow and only accept well known 'icon' values.
  • ui: full width combo-items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants