Skip to content

Add perl as explicit build dependency in EL6/EL8 workflows and spec files#6

Merged
ayanimea merged 2 commits into
feature-alma8from
copilot/sub-pr-2
Mar 8, 2026
Merged

Add perl as explicit build dependency in EL6/EL8 workflows and spec files#6
ayanimea merged 2 commits into
feature-alma8from
copilot/sub-pr-2

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 8, 2026

Makefile.cvs invokes perl to patch the generated configure script, but perl was not listed as an explicit dependency in any of the EL6/EL8 build configurations — relying on it being present in the base image.

Changes

  • .github/workflows/el6.yml: Add perl to yum install in both the build+test step and the RPM build step
  • .github/workflows/el8.yml: Add perl to dnf install
  • build/SPECS/cnee-el6.spec: Add BuildRequires: perl
  • build/SPECS/cnee-el8.spec: Add BuildRequires: perl

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…files

Makefile.cvs uses perl to patch the generated configure script.
Add perl to all relevant yum/dnf install lists and RPM BuildRequires
to ensure builds work in minimal buildroots without relying on perl
being present implicitly.

Co-authored-by: ayanimea <13433370+ayanimea@users.noreply.github.com>
Copilot AI changed the title [WIP] Add GitHub Actions for EL 6 and 8 build processes Add perl as explicit build dependency in EL6/EL8 workflows and spec files Mar 8, 2026
@ayanimea ayanimea requested a review from Copilot March 8, 2026 14:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds perl as an explicit build dependency for Enterprise Linux CI workflows and RPM spec files, aligning the build configuration with the project’s use of perl in Makefile.cvs during make -f Makefile.cvs generate.

Changes:

  • Add perl to EL6 workflow yum install in both build/test and RPM-build container scripts.
  • Add perl to EL8 workflow dnf install dependency list.
  • Add BuildRequires: perl to EL6/EL8 RPM spec files.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/el6.yml Installs perl in CentOS 6 container steps so Makefile.cvs generation doesn’t rely on base image contents.
.github/workflows/el8.yml Installs perl in AlmaLinux 8 container for the same autotools generation path.
build/SPECS/cnee-el6.spec Declares perl as an RPM build requirement for EL6 builds.
build/SPECS/cnee-el8.spec Declares perl as an RPM build requirement for EL8 builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ayanimea ayanimea marked this pull request as ready for review March 8, 2026 14:25
@ayanimea ayanimea merged commit 51b08bf into feature-alma8 Mar 8, 2026
10 checks passed
@ayanimea ayanimea deleted the copilot/sub-pr-2 branch March 8, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants