Skip to content

Fix version assertion case sensitivity and Makefile.am texinfo filename inconsistency#8

Merged
ayanimea merged 2 commits into
feature-alma8from
copilot/sub-pr-2
Mar 8, 2026
Merged

Fix version assertion case sensitivity and Makefile.am texinfo filename inconsistency#8
ayanimea merged 2 commits into
feature-alma8from
copilot/sub-pr-2

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 8, 2026

Two bugs in the e2e test suite and build system identified in review.

tests/e2e_cnee.sh — version assertion case mismatch

xnee_version() prints Xnee (capital X via PACKAGE), but assertions were matching lowercase xnee, causing false failures on case-sensitive grep. Updated to Xnee\|xnee alternation (the helper already converts \| to ERE |):

# Before
assert_output_contains "cnee --version prints 'xnee'" "xnee" "$CNEE" --version

# After
assert_output_contains "cnee --version prints 'xnee'" "Xnee\|xnee" "$CNEE" --version

cnee/src/Makefile.am — inconsistent generated filename in man target

The man target was generating cnee.texinfo, while BUILT_SOURCES, texi_TEXINFOS, CLEAN_FILES, and the standalone cnee.texi rule all use cnee.texi. This left cnee.texinfo uncleaned by make clean. Standardized the man target to output cnee.texi so it's covered by the existing CLEAN_FILES entry.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…nconsistency

Co-authored-by: ayanimea <13433370+ayanimea@users.noreply.github.com>
Copilot AI changed the title [WIP] Add automation for building on Enterprise Linux 6 and 8 Fix version assertion case sensitivity and Makefile.am texinfo filename inconsistency Mar 8, 2026
@ayanimea ayanimea requested a review from Copilot March 8, 2026 15:16
@ayanimea ayanimea marked this pull request as ready for review March 8, 2026 15:22
@ayanimea ayanimea merged commit b47751d into feature-alma8 Mar 8, 2026
6 checks passed
@ayanimea ayanimea deleted the copilot/sub-pr-2 branch March 8, 2026 15:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two independent bugs: a case-sensitivity mismatch in the e2e test suite's version assertions, and an inconsistent generated filename in the cnee/src/Makefile.am man target.

Changes:

  • Updated two assert_output_contains version assertions in tests/e2e_cnee.sh to use the alternation pattern Xnee\|xnee, matching the actual output of xnee_version() which prints PACKAGE (expanded as Xnee).
  • Corrected the man target in cnee/src/Makefile.am to output cnee.texi instead of cnee.texinfo, aligning it with BUILT_SOURCES, CLEAN_FILES, texi_TEXINFOS, and the standalone cnee.texi rule.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/e2e_cnee.sh Fixes two version-check assertions to use case-insensitive alternation Xnee|xnee, preventing false failures when PACKAGE is Xnee.
cnee/src/Makefile.am Fixes the man target to write cnee.texi instead of cnee.texinfo, eliminating the stale file left behind by make clean.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants