Refactoring, fixup of missing variables in animation callback - #4
Open
reinderien wants to merge 4 commits into
Open
Refactoring, fixup of missing variables in animation callback#4reinderien wants to merge 4 commits into
reinderien wants to merge 4 commits into
Conversation
added 4 commits
January 4, 2021 12:53
have worked, because variable `im` was unavailable in the plotting method. It runs, now, although it still isn't "live" - it doesn't update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code wasn't running, and its dependencies were well out-of-date. The code runs, now, and I get a basically smooth updated animation.
The one remaining problem is that you're concatenating spectra in a way that creates a seam, and I think the way to fix this is to concatenate time-domain data instead.