fix: resolve RD and FD Calculator buttons not functioning (#3338, #3336)#3343
Open
ShreyaRHipparagi wants to merge 1 commit intoayush-that:mainfrom
Open
fix: resolve RD and FD Calculator buttons not functioning (#3338, #3336)#3343ShreyaRHipparagi wants to merge 1 commit intoayush-that:mainfrom
ShreyaRHipparagi wants to merge 1 commit intoayush-that:mainfrom
Conversation
…#3338, ayush-that#3336) Root cause: Duplicate element IDs in sip.html caused getElementById to attach event handlers to the wrong buttons (Investment Growth/Tax calculators instead of RD/FD calculators). Changes: - RD Calculator: Changed button IDs to unique calculate-rd-btn and clear-rd-btn - FD Calculator: Changed button IDs to unique calculate-fd-btn and clear-fd-btn - Added missing error message divs (installmentError, rateError, monthsError, principalError, fdRateError, yearsError) - Updated RDCalculator.js and FDCalculator.js to reference new IDs Fixes ayush-that#3338 Fixes ayush-that#3336
|
Someone is attempting to deploy a commit to the Ayush Kumar Singh's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your chaotic pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: Duplicate element IDs in sip.html caused getElementById to attach event handlers to the wrong buttons (Investment Growth/Tax calculators instead of RD/FD calculators).
Changes:
Fixes #3338
Fixes #3336
🛠️ Fixes Issue
Fixes: #<issue_number>
👨💻 Description
What does this PR do?
📄 Type of Change
📷 Screenshots/GIFs (if any)
Include screenshots or GIFs to demonstrate your changes
✅ Checklist
Mandatory Tasks
🤝 GSSoC Participation