Skip to content

fix: resolve RD and FD Calculator buttons not functioning (#3338, #3336)#3343

Open
ShreyaRHipparagi wants to merge 1 commit intoayush-that:mainfrom
ShreyaRHipparagi:fix/rd-fd-calculator-buttons
Open

fix: resolve RD and FD Calculator buttons not functioning (#3338, #3336)#3343
ShreyaRHipparagi wants to merge 1 commit intoayush-that:mainfrom
ShreyaRHipparagi:fix/rd-fd-calculator-buttons

Conversation

@ShreyaRHipparagi
Copy link
Copy Markdown

Root cause: Duplicate element IDs in sip.html caused getElementById to attach event handlers to the wrong buttons (Investment Growth/Tax calculators instead of RD/FD calculators).

Changes:

  • RD Calculator: Changed button IDs to unique calculate-rd-btn and clear-rd-btn
  • FD Calculator: Changed button IDs to unique calculate-fd-btn and clear-fd-btn
  • Added missing error message divs (installmentError, rateError, monthsError, principalError, fdRateError, yearsError)
  • Updated RDCalculator.js and FDCalculator.js to reference new IDs

Fixes #3338
Fixes #3336

🛠️ Fixes Issue

Fixes: #<issue_number>

👨‍💻 Description

What does this PR do?

  • Briefly describe the feature or bug fix you've implemented.
  • Highlight any major changes or added functionality.
  • Mention how it enhances the project.

📄 Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

📷 Screenshots/GIFs (if any)

Include screenshots or GIFs to demonstrate your changes

✅ Checklist

  • I am a participant of GSSoC-ext.
  • I have followed the contribution guidelines of this project.
  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added documentation to explain my changes.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🤝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

…#3338, ayush-that#3336)

Root cause: Duplicate element IDs in sip.html caused getElementById to attach
event handlers to the wrong buttons (Investment Growth/Tax calculators instead
of RD/FD calculators).

Changes:
- RD Calculator: Changed button IDs to unique calculate-rd-btn and clear-rd-btn
- FD Calculator: Changed button IDs to unique calculate-fd-btn and clear-fd-btn
- Added missing error message divs (installmentError, rateError, monthsError,
  principalError, fdRateError, yearsError)
- Updated RDCalculator.js and FDCalculator.js to reference new IDs

Fixes ayush-that#3338
Fixes ayush-that#3336
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 2, 2026

Someone is attempting to deploy a commit to the Ayush Kumar Singh's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026

Thank you for submitting your chaotic pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from FinVeda team will review it as soon as possible. We appreciate your support in making this project better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: RD Calculator Buttons Not Functioning BUG: FD Calculator Buttons Not Functioning

1 participant