Address feedback on serialization safety in AZRankingWidget #after_build callback#5322
Closed
Copilot wants to merge 1 commit intoissue/5156from
Closed
Address feedback on serialization safety in AZRankingWidget #after_build callback#5322Copilot wants to merge 1 commit intoissue/5156from
Copilot wants to merge 1 commit intoissue/5156from
Conversation
Copilot
AI
changed the title
[WIP] WIP address feedback on update preview and add another item reorder issue
Address feedback on serialization safety in AZRankingWidget #after_build callback
Feb 18, 2026
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses review feedback on PR #5309 regarding the use of
[$this, 'afterBuildRebuildPreview']in the#after_buildcallback.No code changes required. The current implementation using instance method references is safe because:
AZRankingWidgetextendsWidgetBase→PluginBase, which usesDependencySerializationTrait$this->entityTypeManager,$this->rankingImageHelper)afterBuildRebuildPreviewmethod requires instance context and cannot be made static without significant refactoringThe original concern about serialization during form rebuilds is addressed by Drupal's plugin system architecture.
Related issues
Related to #5309
How to test
No changes to test - this PR documents the architectural decision to keep the existing implementation.
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.