Update drupal/config_distro requirement from 2.1.0-alpha1 to 2.1.0-alpha2#5341
Update drupal/config_distro requirement from 2.1.0-alpha1 to 2.1.0-alpha2#5341dependabot[bot] wants to merge 3 commits intomainfrom
Conversation
Updates the requirements on drupal/config_distro to permit the latest version. --- updated-dependencies: - dependency-name: drupal/config_distro dependency-version: 2.1.0-alpha2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
added
the
dependencies
|
https://www.drupal.org/project/config_distro/releases/2.1.0-alpha2
|
bberndt-uaz
added
Drupal
|
@joeparsons removal of the patch appears to break the ability to selectively import a subset of the distribution updates. To reproduce:
It's never really been clear to me if this is the intended functioning of config distro or not, but it's been Quickstart's behavior in the past for convenience. I'm working on rerolling the patch, but maybe we should create an issue about this if it seems like a good idea. |
@tadean Yes, I think we should definitely create a d.o. issue about this. Thanks! |
|
Tugboat has finished building the preview for this pull request! Link: Dashboard: |
| "drupal/config_distro": { | ||
| "Storage comparer issue": "https://gist.githubusercontent.com/tadean/e2e0dd57f1a9c4eae28d8e713cb01d82/raw/e114987d4a76c183208c763de4dbfecbf41b7f35/config_distro_storage_comparer_issue.patch" | ||
| }, | ||
| "drupal/config_readonly": { |
There was a problem hiding this comment.
| "drupal/config_readonly": { | |
| "drupal/config_distro": { | |
| "Storage comparer issue": "https://gist.githubusercontent.com/tadean/b0d39ae5fa2b03b84ea398c1e896e6bf/raw/2430ef1a7d8056c04eb2191160382f9bc6e2312a/config_distro_storage_comparer_issue_alpha2.patch" | |
| }, | |
| "drupal/config_readonly": { |
Here is a potential rerolled version of the patch for the alpha2 changes.
I looked into this bug some more and the mechanism appears to be that without the patch, deselecting a module before import (to avoid importing its changes) can result in the changes being imported anyway, but not added to the config_sync snapshot, so thereafter the changes are considered customizations in some cases.
I'm working on replicating a set of testing steps to reproduce on a non-quickstart site for a write-up on drupal.org.
|
A newer version of drupal/config_distro exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
This isn't needed for 3.3.1. |
5 participants
Updates the requirements on drupal/config_distro to permit the latest version.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)