Draft
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5405.
Summary
Convert the AZ Navbar Twig override in
az_barriointo a Single Directory Component.This extracts the recursive navbar markup into a theme SDC, keeps the existing menu template as a thin presenter, and moves the navbar hover JavaScript into the component so the markup and behavior now live together.
Changes
az_main_navbarSDC inthemes/custom/az_barrio/components/az_main_navbar/menu--main-navbar-az.html.twigto render the SDC instead of owning the recursive menu macro directlyaz_main_navbar.jsaz-navbar-hoverlibrary definition and obsolete JS fileAzBarrioTestto enableaz_navbarduring the test and verify the navbar variation and component-owned JS render correctlyWhy
This continues the az_barrio SDC exploration with a more complex example than breadcrumb.
AZ Navbar was a useful next target because it exercises:
Testing
lando drush crlando phpunit --filter AzBarrioTestNotes
Attributeobjects across the SDC boundary caused component validation errorsaz_migration