Skip to content

#5372: Add PHP 8.4 deprecations patch for seboettg/citeproc-php.#5420

Merged
bberndt-uaz merged 1 commit intomainfrom
issue/5372-php84
Mar 18, 2026
Merged

#5372: Add PHP 8.4 deprecations patch for seboettg/citeproc-php.#5420
bberndt-uaz merged 1 commit intomainfrom
issue/5372-php84

Conversation

@joeparsons
Copy link
Copy Markdown
Member

@joeparsons joeparsons commented Mar 17, 2026

Description

Adds a patch for seboettg/citeproc-php that addresses PHP 8.4 deprecations.

The PHP 8.4 deprecations (and existing GitHub issue/PR) were discovered while working on #5373 (for PHP 8.5).

This should probably be included in 3.3.x since we plan to start using PHP 8.4 by default on Pantheon with 3.3.0.

Related issues

Discovered while working on #5373 for #5372.

How to test

  • Create and edit publications on PHP >= 8.4
  • Ensure no PHP deprecation warnings are triggered

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@joeparsons joeparsons self-assigned this Mar 17, 2026
@joeparsons joeparsons added bug Something isn't working dependencies Pull requests that update a dependency file php Pull requests that update Php code publications 3.3.x only labels Mar 17, 2026
@joeparsons joeparsons moved this from Todo to In Progress in 3.3.0-alpha2 Mar 17, 2026
@joeparsons joeparsons marked this pull request as ready for review March 17, 2026 23:49
@joeparsons joeparsons requested review from a team as code owners March 17, 2026 23:49
@joeparsons joeparsons moved this from In Progress to Needs review in 3.3.0-alpha2 Mar 17, 2026
@djcelaya
Copy link
Copy Markdown
Contributor

How do I reproduce the deprecation warning? I think I saw it once on a local vanilla build but now it's gone.

@github-project-automation github-project-automation bot moved this from Needs review to Ready to merge in 3.3.0-alpha2 Mar 18, 2026
@bberndt-uaz bberndt-uaz merged commit 4894235 into main Mar 18, 2026
32 checks passed
@bberndt-uaz bberndt-uaz deleted the issue/5372-php84 branch March 18, 2026 17:20
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in 3.3.0-alpha2 Mar 18, 2026
bberndt-uaz pushed a commit that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.x only bug Something isn't working dependencies Pull requests that update a dependency file php Pull requests that update Php code publications

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants