Closes #5371: Add FAQ Schema + Checkbox to Accordions

[kevdevlu]

Description

Issue #5371

Release notes

Related issues

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

• Patch release changes
  • Bug fix
  • Accessibility, performance, or security improvement
  • Critical institutional link or brand change
  • Adding experimental module
  • Update experimental module
• Minor release changes
  • New feature
  • Breaking or visual change to existing behavior
  • Upgrade experimental module to stable
  • Enable existing module by default or database update
  • Non-critical brand change
  • New internal API or API improvement with backwards compatibility
  • Risky or disruptive cleanup to comply with coding standards
  • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
• Other or unknown
  • Other or unknown

Drupal core

• Patch release changes
  • Security update
  • Patch level release (non-security bug-fix release)
  • Patch removal that's no longer necessary
• Minor release changes
  • Major or minor level update
• Other or unknown
  • Other or unknown

Drupal contrib projects

• Patch release changes
  • Security update
  • Patch or minor level update
  • Add new module
  • Patch removal that's no longer necessary
• Minor release changes
  • Major level update
• Other or unknown
  • Other or unknown

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My change requires release notes.

[az-digital-bot]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr5444-wgq7bvxavbxh7qsisuihmis3hajenmpv.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/69c5b799d5d87f969e6e9144

[camikazegreen]

This is pretty cool. A couple of things that I noticed in my testing:

• Selecting the FAQ checkbox seems to change the behavior of any Accordions that were selected to be open by default so that all accordions are collapsed by default.
• I don't know whether or not this matters, but the formatting of the schema metatags seems to be broken when I view source of the page. Other examples of schema.org metatags seem to pretty-print, but these metatags are all in one line that doesn't break.

[joshuasosa]

FYI PR #5364 includes some similar accordion changes (e.g., adding a new accordion behavior). If that one gets merged, this PR may need some reconciliation.

[joshuasosa]

Descriptions should be more generic since the behavior can be used for more than just "FAQ schema markup options."

[joshuasosa]

• Selecting the FAQ checkbox seems to change the behavior of any Accordions that were selected to be open by default so that all accordions are collapsed by default.

If you're testing using demo content, I believe this is a quirk of the demo content import. See #5366.

[kevdevlu]

Thanks for all the feedback guys! Currently getting feedback from Ryan Dool. If he thinks this is a feasible way, then i'll definitely address

1. the AZAccordionParagraphBehavior.php description
2. pretty print of JSON
3. any merge conflicts with Closes #4343 Adds accordion expand/collapse all option #5364
4. the bug from az_demo for accordions Accordion demo content imports unchecked 'collapsed' option as 'null' #5366