Load with the new configuration by PkllonG · Pull Request #171 · azerothcore/mod-cfbg

PkllonG · 2026-06-23T02:48:55Z

Summary by CodeRabbit

Refactor
- Reworked battleground configuration loading to use a cached configuration layer for reliable access to feature flags and thresholds.
- Added support for parsing and applying WG skip-class lists from the configured comma-separated values.
- Updated configuration loading to accept an optional reload parameter.
Behavioral Updates
- Config reload behavior is now respected during post-configuration load handling.
- Balance/team setting values are now read from the cached source (including updated balance level range outputs).

coderabbitai · 2026-06-23T02:49:13Z

📝 Walkthrough

Walkthrough

CFBG::LoadConfig transitions from direct sConfigMgr reads into stored member fields to a cache-backed model using ConfigValueCache. A CFBGOutConfig enum and CFBGOutConfigData class are introduced; all public CFBG accessors are rewired to read from the cache; stored config members are consolidated into _OutConfigData; a LoadWGSkipClasses helper parses the skip-classes string; and the reload signal is propagated through CFBG_World::OnAfterConfigLoad.

Changes

CFBG Config-Cache Refactor

Layer / File(s)	Summary
CFBGOutConfig enum, CFBGOutConfigData class, and member field changes `src/CFBG.h`	Adds `Config.h` and `ConfigValueCache.h` includes, declares the `CFBGOutConfig` enum with all config keys and `CFBGOutConfigData` (derived from `ConfigValueCache<CFBGOutConfig>`) with a `BuildConfigCache` hook, and replaces prior per-field stored members with a single `_OutConfigData` field plus `_wgSkipClasses`.
LoadConfig, BuildConfigCache, LoadWGSkipClasses, and accessor rewrites `src/CFBG.h`, `src/CFBG.cpp`	Rewrites all public `CFBG` config accessors to read from `_OutConfigData.GetConfigValue<...>(CFBGOutConfig::...)` instead of member fields, updates `LoadConfig` signature to `LoadConfig(bool reload)` and delegates to `_OutConfigData.Initialize`, adds `LoadWGSkipClasses` declaration and set-based `IsWGSkipClass`, and implements `LoadWGSkipClasses` (comma-token parser) and `CFBGOutConfigData::BuildConfigCache` (registers all config entries via `SetConfigValue` with early-return guard when disabled).
Config reload parameter propagation `src/CFBG_SC.cpp`	`CFBG_World::OnAfterConfigLoad` now forwards the `Reload` parameter to `sCFBG->LoadConfig(Reload)` instead of calling with no arguments.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

azerothcore/mod-cfbg#169: Both PRs implement the Wintergrasp class-skip feature by parsing CFBG.Battlefield.SkipClasses into _wgSkipClasses and using it via IsWGSkipClass to bypass cross-faction/morph logic.
azerothcore/mod-cfbg#170: Both PRs touch the CFBG skip-classes parsing/tokenization in src/CFBG.cpp (main PR moves it into LoadWGSkipClasses/config caching while retrieved PR tweaks how CFBG.Battlefield.SkipClasses is tokenized into _wgSkipClasses).

Poem

🐇 Hoppity-hop through the config cache lane,
No more raw fields scattered like rain!
Each value now cached with a neat little key,
BuildConfigCache runs so tidy and free.
The rabbit approves — clean config is the way! 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is vague and generic, using non-descriptive phrasing that doesn't clearly convey the main changes being made to the codebase.	Revise the title to be more specific about the actual changes, such as 'Refactor CFBG configuration to use cached config-data model' or 'Add LoadConfig reload parameter and config-cache architecture'.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/CFBG.cpp`:
- Around line 109-119: The early return check on line 109 prevents the
LoadWGSkipClasses call on line 118 from executing when the system is disabled,
causing the _wgSkipClasses cache to retain stale values during a reload
transition from enabled to disabled. To fix this, ensure the skip-class cache is
cleared even when the system is disabled by either calling
sCFBG->LoadWGSkipClasses before the early return statement, or by adding a cache
clearing call in the early return path to reset _wgSkipClasses when the system
is disabled.

In `@src/CFBG.h`:
- Line 153: The LoadConfig() method signature in CFBG.h has been updated to
require a bool reload parameter, but the call to LoadConfig() in src/CFBG_SC.cpp
at line 406 (likely within the OnAfterConfigLoad function) was not updated and
still uses the old zero-argument syntax. Update this LoadConfig() call to pass
the bool reload parameter, using the Reload parameter available in the
OnAfterConfigLoad context.
- Around line 155-172: In all the getter methods between IsEnableSystem() and
RandomizeRaces() (18 methods total), replace the enum name
CrossFactionBGOutConfig with CFBGOutConfig. The _OutConfigData member is typed
as ConfigValueCache<CFBGOutConfig>, so all GetConfigValue template calls must
reference the correct enum CFBGOutConfig instead of the undefined
CrossFactionBGOutConfig. Update each inline method to use CFBGOutConfig:: as the
prefix for the configuration keys.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f5ba9957-15eb-44d0-b63c-49f9c6959837

📥 Commits

Reviewing files that changed from the base of the PR and between 902f3af and fce3ab6.

📒 Files selected for processing (2)

src/CFBG.cpp
src/CFBG.h

PkllonG · 2026-06-23T03:02:27Z

@coderabbitai

coderabbitai · 2026-06-23T03:02:43Z

@PkllonG It looks like you tagged me without a specific request — I'll go ahead and review the changes in this PR!

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

PkllonG · 2026-06-23T03:03:34Z

@coderabbitai review

coderabbitai · 2026-06-23T03:03:41Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

FrancescoBorzi · 2026-07-02T16:40:14Z

+{
+    SetConfigValue<bool>(CFBGOutConfig::_IsEnableSystem, "CFBG.Enable", false);
+    if (!sCFBG->IsEnableSystem())
+        return;


this early return could crash the worldserver at startup when CFBG.Enable = 0:

because Initialize() calls VerifyAllConfigsLoaded() after BuildConfigCache() and it asserts on any config slot that was never set.

Running with the module compiled but disabled is a normal setup, so we should load all values unconditionally and keep the enable check at the call sites, like WorldConfig::BuildConfigCache does in the core.

FrancescoBorzi · 2026-07-02T16:40:41Z

-    _balanceClassMaxLevel = sConfigMgr->GetOption<uint8>("CFBG.BalancedTeams.Class.MaxLevel", 19);
-    _balanceClassLevelDiff = sConfigMgr->GetOption<uint8>("CFBG.BalancedTeams.Class.LevelDiff", 2);
-    _randomizeRaces = sConfigMgr->GetOption<bool>("CFBG.RandomRaceSelection", true);
+    SetConfigValue<bool>(CFBGOutConfig::_IsEnableWGSystem, "CFBG.Battlefield.Enable", false);


the old default for CFBG.Battlefield.Enable was true, with false here anyone without the key in their conf silently loses the Wintergrasp integration

FrancescoBorzi · 2026-07-02T16:40:58Z

+    sCFBG->LoadWGSkipClasses(sCFBG->IsEnableWGSkipClasses());
+
+    SetConfigValue<bool>(CFBGOutConfig::_IsEnableBalancedTeams, "CFBG.BalancedTeams", false);
+    SetConfigValue<bool>(CFBGOutConfig::_IsEnableBalanceClassLowLevel, "CFBG.BalancedTeams.Class.LowLevel", false);


same here, the old default for CFBG.BalancedTeams.Class.LowLevel was true.

FrancescoBorzi · 2026-07-02T16:42:26Z

+    SetConfigValue<bool>(CFBGOutConfig::_IsEnableWGReapplyOnResurrect, "CFBG.Battlefield.ReapplyOnResurrect.Enable", true);
+
+    SetConfigValue<std::string>(CFBGOutConfig::_IsEnableWGSkipClasses, "CFBG.Battlefield.SkipClasses", "");
+    sCFBG->LoadWGSkipClasses(sCFBG->IsEnableWGSkipClasses());


this getter returns the skip class list rather than a flag, maybe GetWGSkipClasses would read better than IsEnableWGSkipClasses

Add files via upload

fce3ab6

coderabbitai Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread src/CFBG.cpp

Comment thread src/CFBG.h

Comment thread src/CFBG.h Outdated

PkllonG added 2 commits June 23, 2026 10:57

Update CFBG.h

a82f148

Add files via upload

72af11c

PkllonG changed the title ~~Add files via upload~~ Load with the new configuration Jun 23, 2026

FrancescoBorzi reviewed Jul 2, 2026

View reviewed changes

PkllonG closed this Jul 2, 2026

Uh oh!

Conversation

PkllonG commented Jun 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PkllonG commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PkllonG commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FrancescoBorzi Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

FrancescoBorzi Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

FrancescoBorzi Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

FrancescoBorzi Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PkllonG commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading