Skip to content

fix: balancing tie fold #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrancescoBorzi merged 2 commits into from
Jul 2, 2026
Merged

fix: balancing tie fold #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ceeb95
fix: stop flipping tie candidates off their native faction
FrancescoBorzi Jul 2, 2026
88544d7
fix: document Avg.Ilvl knob only applies when BalancedTeams is off
FrancescoBorzi Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion conf/CFBG.conf.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@
# Default: "" - (no class skipped)
#
# CFBG.Include.Avg.Ilvl.Enable
# Description: Enable check average item level for bg
# Description: Enable check average item level for bg.
# Only takes effect when CFBG.BalancedTeams = 0. When
# CFBG.BalancedTeams = 1 the average item level is always
# consulted as an intrinsic tiebreaker of the balancing
# cascade, regardless of this setting.
# Default: 0
#
# CFBG.BalancedTeams
Expand Down
10 changes: 2 additions & 8 deletions src/CFBG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,11 @@ TeamId CFBG::ResolveBalancedTeam(TeamBalanceContext const& ctx)

if (std::abs(avgLvlAlliance - avgLvlHorde) >= 0.5f)
team = avgLvlAlliance < avgLvlHorde ? TEAM_ALLIANCE : TEAM_HORDE;
else // it's balanced, so we should only check the ilvl
else if (ctx.avgIlvlA != ctx.avgIlvlH) // levels balanced, ilvl breaks the tie; an exact ilvl tie keeps the current pick
team = ctx.avgIlvlA < ctx.avgIlvlH ? TEAM_ALLIANCE : TEAM_HORDE;
}
}
else if (ctx.levelSumA == ctx.levelSumH)
else if (ctx.levelSumA == ctx.levelSumH && ctx.avgIlvlA != ctx.avgIlvlH)
{
team = ctx.avgIlvlA < ctx.avgIlvlH ? TEAM_ALLIANCE : TEAM_HORDE;
}
Expand Down Expand Up @@ -781,12 +781,6 @@ void CFBG::SelectBalancedGroups(BattlegroundQueue* queue, BattlegroundBracketId
ctx.levelSumA = baseLevelSum[TEAM_ALLIANCE] + stagedLevelSum[TEAM_ALLIANCE];
ctx.levelSumH = baseLevelSum[TEAM_HORDE] + stagedLevelSum[TEAM_HORDE];

// Fold the candidate's level sum into its projected side.
if (gInfo->teamId == TEAM_ALLIANCE)
ctx.levelSumA += cfInfo.SumPlayerLevel;
else
ctx.levelSumH += cfInfo.SumPlayerLevel;

// ilvl metric: live BG average when reinforcing, staged sums at formation.
ctx.avgIlvlA = bg ? GetBGTeamAverageItemLevel(bg, TEAM_ALLIANCE) : stagedIlvlSum[TEAM_ALLIANCE];
ctx.avgIlvlH = bg ? GetBGTeamAverageItemLevel(bg, TEAM_HORDE) : stagedIlvlSum[TEAM_HORDE];
Expand Down
2 changes: 1 addition & 1 deletion src/CFBG.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ struct TeamBalanceContext
{
int32 countA{ 0 }; // head counts, candidate EXCLUDED
int32 countH{ 0 };
uint32 levelSumA{ 0 }; // candidate level ALREADY folded into its side
uint32 levelSumA{ 0 }; // level sums, candidate EXCLUDED (like the counts)
uint32 levelSumH{ 0 };
uint32 avgIlvlA{ 0 }; // per-team ilvl metric (bg avg OR queue sum)
uint32 avgIlvlH{ 0 };
Expand Down
Loading