Skip to content

fix: hook polish name cache - #177

Merged
FrancescoBorzi merged 6 commits into
masterfrom
fix-hook-polish-name-cache
Jul 2, 2026
Merged

fix: hook polish name cache#177
FrancescoBorzi merged 6 commits into
masterfrom
fix-hook-polish-name-cache

Conversation

@FrancescoBorzi

Copy link
Copy Markdown

No description provided.

_fakeNamePlayersStore has had no writer since the 2019 repo import, so
the leave-side invalidation path (DoForgetPlayersInList and its store,
flags and callers) has never sent a packet. Remove it whole; the live
BG-entry invalidation (DoForgetPlayersInBG) is untouched. With the
false leg gone every FitPlayerInTeam caller passed action=true, so the
parameter goes too.
OnPlayerBeforeUpdate decremented one 10s counter shared by every online
player, so whoever ticked when it expired got served and everyone else
waited for a later window: fresh BG entrants could keep stale cached
names/races for many seconds. A const, non-inserting per-player flag
probe now serves a flagged player on their first update tick; the flag
set/clear cycle self-rate-limits, so no timer is needed.
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@FrancescoBorzi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 33e6ff23-52b5-48cb-89dc-fd04e5b9edf8

📥 Commits

Reviewing files that changed from the base of the PR and between 902f3af and 65868e4.

📒 Files selected for processing (4)
  • src/CFBG.cpp
  • src/CFBG.h
  • src/CFBG_SC.cpp
  • src/cs_cfbg.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-hook-polish-name-cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@FrancescoBorzi
FrancescoBorzi merged commit 42b8846 into master Jul 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant