fix: even out lopsided teams when the battleground starts

[FrancescoBorzi]

No description provided.

[coderabbitai]

Warning

Review limit reached

@FrancescoBorzi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 278169eb-84e6-4bc3-a9c1-73080db90421

📥 Commits

Reviewing files that changed from the base of the PR and between 8a29b6a and 4ba4066.

📒 Files selected for processing (4)

• conf/CFBG.conf.dist
• src/CFBG.cpp
• src/CFBG.h
• src/CFBG_SC.cpp

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/balance-teams-at-start

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR adds a new “doors-open” balancing pass to repair large team imbalances caused by declined/no-show invites, by flipping eligible solo players at battleground start while avoiding splitting real premades.

Changes:

• Added a new config toggle (CFBG.BalanceTeamsAtStart.Enabled) and internal flag/getter to control start-time balancing.
• Implemented BalanceTeamsAtStart() plus a shared helper IsPartyCommittedToBG() to avoid splitting premades when rebalancing.
• Switched scripting to run the new balancing logic on OnBattlegroundStart and added a faction-update hook to keep m_team aligned for faked BG players across core faction resets.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/CFBG.h	Declares the new start-time balancing API and config flag.
src/CFBG.cpp	Implements start-time balancing, premade-commit detection, and adds debug logging for projection clamping.
src/CFBG_SC.cpp	Wires balancing to battleground start and adds a player faction-update hook to preserve BG fake team.
conf/CFBG.conf.dist	Documents and defaults the new CFBG.BalanceTeamsAtStart.Enabled setting.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.