Skip to content

fix(WG): credit Victory in Wintergrasp for crossfaction players #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nyeriah merged 1 commit into from
Jul 19, 2026
Merged

fix(WG): credit Victory in Wintergrasp for crossfaction players #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions src/CFBG_SC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ class CFBG_Player : public PlayerScript
static constexpr uint32 WG_SPELL_LIEUTENANT = 55629;
static constexpr uint32 WG_NPC_QUEST_PVP_KILL_ALLIANCE = 31086;
static constexpr uint32 WG_NPC_QUEST_PVP_KILL_HORDE = 39019;
static constexpr uint32 WG_QUEST_VICTORY_ALLIANCE = 13181;
static constexpr uint32 WG_QUEST_VICTORY_HORDE = 13183;

class CFBG_Battlefield : public BattlefieldScript
{
Expand Down Expand Up @@ -457,11 +459,32 @@ class CFBG_Battlefield : public BattlefieldScript
// war set still reflects who was actively fighting. ClearFakePlayer
// is a no-op for unfaked players, so iterating GUIDs that may or may
// not be faked is safe.

// "Victory in Wintergrasp": OnBattleEnd credits the winners with the
// quest of the defending (= winning) team only, which misses cross-
// faction players holding their native faction's copy. Grant the other
// one here -- AreaExploredOrEventHappens is a no-op on a quest the
// player does not hold, and core still grants its own right after.
uint32 const otherVictoryQuest = bf->GetDefenderTeam() == TEAM_ALLIANCE ? WG_QUEST_VICTORY_HORDE
: WG_QUEST_VICTORY_ALLIANCE;

for (uint8 team = 0; team < PVP_TEAMS_COUNT; ++team)
{
bool const isWinner = static_cast<TeamId>(team) == bf->GetDefenderTeam();

for (ObjectGuid const& guid : bf->GetPlayersInWarSet(static_cast<TeamId>(team)))
if (Player* player = ObjectAccessor::FindPlayer(guid))
if (sCFBG->IsPlayerFake(player))
sCFBG->ClearFakePlayer(player);
{
Player* player = ObjectAccessor::FindPlayer(guid);
if (!player)
continue;

if (isWinner)
player->AreaExploredOrEventHappens(otherVictoryQuest);

if (sCFBG->IsPlayerFake(player))
sCFBG->ClearFakePlayer(player);
}
}

// Lock is per-war: drop assignments so the next war re-balances.
sCFBG->ClearWGWarAssignments();
Expand Down
Loading