Skip to content

Add command to schedule the Joyous Journeys event - #46

Merged
Nyeriah merged 2 commits into
azerothcore:masterfrom
Nyeriah:jj-schedule
Jul 23, 2026
Merged

Add command to schedule the Joyous Journeys event#46
Nyeriah merged 2 commits into
azerothcore:masterfrom
Nyeriah:jj-schedule

Conversation

@Nyeriah

@Nyeriah Nyeriah commented Jul 23, 2026

Copy link
Copy Markdown
Member

What

Adds .weekendxp joyousjourneys schedule (SEC_ADMINISTRATOR, console allowed) to define when the Joyous Journeys event starts and ends:

  • .weekendxp joyousjourneys schedule 2026-08-01 2026-08-31 sets the window (dates are YYYY-MM-DD, inclusive, server local time)
  • .weekendxp joyousjourneys schedule shows the current schedule and whether the event is active
  • .weekendxp joyousjourneys schedule clear removes it

While a schedule is set it takes precedence over the XPWeekend.IsJoyousJourneysActive config flag, for both the XP and reputation bonuses. The login announcement then tells players the exact date the event ends; without a schedule the previous generic message is kept.

How

The start/end timestamps are persisted in the characters DB worldstates table via sWorldState (indices 97301/97302), so the schedule survives restarts without a new table. Invalid calendar dates (e.g. 2026-02-30) and end-before-start are rejected. Also adds the command table help entry and a note in the conf.dist.

Tests

  • Built the modules project (MSVC Release) cleanly.

🤖 Generated with Claude Code

Adds .weekendxp joyousjourneys schedule <start> <end> (admin only) to set
the event window with YYYY-MM-DD dates, stored in the characters DB
worldstates table so it survives restarts. While a schedule is set it
overrides the XPWeekend.IsJoyousJourneysActive config, and the login
message shows the date the event ends. Running the command without
arguments shows the current schedule, clear removes it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Nyeriah, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbc51eef-3dd4-4d02-a06f-2a8f1b7c5c96

📥 Commits

Reviewing files that changed from the base of the PR and between 6fdbace and d0e3aee.

📒 Files selected for processing (3)
  • conf/mod-double-xp-weekend.conf.dist
  • data/sql/db-world/mod-weekend-xp-texts.sql
  • src/mod-double-xp-weekend.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Moves the new schedule command and login outputs to module_string ids
3-8 with locales, matching ids 0-2. Messages are parsed with
PGetParseModuleString and sent via SendSysMessage because
PSendModuleSysMessage drops output for sessionless (console) handlers.
Date formatting now uses Acore::Time::TimeToTimestampStr instead of a
hand-rolled strftime helper.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Nyeriah
Nyeriah merged commit 504411a into azerothcore:master Jul 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant