Skip to content

chore: upgrade Angular to v22.0.2 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Helias merged 2 commits into from
Jun 20, 2026
Merged

chore: upgrade Angular to v22.0.2 #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b6442c
chore: upgrade Angular to v22.0.2
Helias Jun 20, 2026
23f27e9
ci: bump CI Node to 24 for Angular 22
Helias Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24

- name: Add conf
run: cp config.ts.dist config.ts
Expand Down
4,036 changes: 1,979 additions & 2,057 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

31 changes: 16 additions & 15 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,30 +11,31 @@
},
"private": true,
"dependencies": {
"@angular/animations": "21.2.17",
"@angular/common": "21.2.17",
"@angular/compiler": "21.2.17",
"@angular/core": "21.2.17",
"@angular/forms": "21.2.17",
"@angular/platform-browser": "21.2.17",
"@angular/platform-browser-dynamic": "21.2.17",
"@angular/router": "21.2.17",
"@angular/animations": "22.0.2",
"@angular/common": "22.0.2",
"@angular/compiler": "22.0.2",
"@angular/core": "22.0.2",
"@angular/forms": "22.0.2",
"@angular/platform-browser": "22.0.2",
"@angular/platform-browser-dynamic": "22.0.2",
"@angular/router": "22.0.2",
"bootstrap": "5.3.5",
"bootswatch": "5.3.5",
"rxjs": "6.6.7",
"serialize-javascript": "3.1.0",
"tslib": "2.0.0",
"tslib": "2.8.1",
"zone.js": "0.15.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "21.2.16",
"@angular/cli": "21.2.16",
"@angular/compiler-cli": "21.2.17",
"@angular/language-service": "21.2.17",
"@angular-devkit/build-angular": "22.0.3",
"@angular/cli": "22.0.3",
"@angular/compiler-cli": "22.0.2",
"@angular/language-service": "22.0.2",
"@types/jasmine": "3.6.0",
"@types/jasminewd2": "2.0.3",
"@types/node": "22.14.0",
"codelyzer": "6.0.0",
"istanbul-lib-instrument": "^6.0.3",
Comment on lines +14 to +38

@coderabbitai coderabbitai Bot Jun 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== package.json engines =="
cat package.json | jq '.engines // "NO_ENGINES_FIELD"'

echo
echo "== Node version pins in common toolchain files =="
fd -HI '(^\.nvmrc$|^\.node-version$|^\.tool-versions$|^Dockerfile$|^Dockerfile\..*$|^package\.json$|^.*\.yml$|^.*\.yaml$)'

echo
echo "== Node version references in repo (CI/Docker/tooling) =="
rg -n --hidden --glob '!node_modules/**' --glob '!.git/**' \
  'node-version|setup-node|FROM node|\"engines\"|\"node\"'

Repository: azerothcore/server-status

Length of output: 439

🏁 Script executed:

cat -n package.json | head -60

Repository: azerothcore/server-status

Length of output: 1825

🏁 Script executed:

cat -n .github/workflows/tests.yml

Repository: azerothcore/server-status

Length of output: 815

🌐 Web query:

Angular 22.0.2 Node.js version requirements compatibility

💡 Result:

For Angular 22.0.2, the supported Node.js version requirement is given by Angular’s “engines.node” range for the Angular 22 line: ^22.22.3 || ^24.15.0 || >=26.0.0. [1] So, to be compatible with Angular 22.0.2, use: - Node.js 22 >= 22.22.3 - or Node.js 24 >= 24.15.0 - or Node.js 26.0.0+ [1] Angular 22 also reflects that Node.js v20 is no longer supported (minimum bumped to the Node 22/24 versions above). [2] Confidence: High (the Node.js range is directly sourced from Angular’s compatibility table update/engines metadata in the Angular repo). [1][2]

Citations:

🌐 Web query:

TypeScript 6.0.3 release version exists official

💡 Result:

Yes, TypeScript 6.0.3 is an official release [1][2]. It was published to the npm registry on April 16, 2026 [2]. As of June 20, 2026, it is listed as a stable release within the official Microsoft TypeScript GitHub repository [3][1].

Citations:

🏁 Script executed:

rg -n "typescript" package.json

Repository: azerothcore/server-status

Length of output: 98

Add engines field to package.json to document Node.js compatibility for local development.

Angular 22.0.2 requires Node.js ^22.22.3, ^24.15.0, or >=26.0.0. While your CI workflow correctly pins Node.js 24, adding an explicit engines constraint in package.json will help local developers detect version mismatches without running CI first.

"engines": {
  "node": "^22.22.3 || ^24.15.0 || >=26.0.0"
}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` around lines 14 - 38, Add an engines field to the root level of
package.json to explicitly document the Node.js version requirements for this
project. The engines field should be placed alongside the existing dependencies
and devDependencies objects and should specify the compatible Node.js versions
that Angular 22.0.2 requires. This will help local developers identify version
mismatches early without needing to run CI.

"jasmine-core": "3.6.0",
"jasmine-spec-reporter": "5.0.0",
"karma": "^6.4.4",
Expand All @@ -45,6 +46,6 @@
"protractor": "7.0.0",
"ts-node": "7.0.0",
"tslint": "6.1.0",
"typescript": "5.9.3"
"typescript": "6.0.3"
}
}
}
4 changes: 2 additions & 2 deletions src/app/app.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
import { provideHttpClient, withInterceptorsFromDi, withXhr } from '@angular/common/http';
import { provideHttpClientTesting } from '@angular/common/http/testing';
import { TestBed, waitForAsync } from '@angular/core/testing';
import { AppComponent } from './app.component';
Expand All @@ -7,7 +7,7 @@ describe('AppComponent', () => {
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [AppComponent],
providers: [provideHttpClient(withInterceptorsFromDi()), provideHttpClientTesting()],
providers: [provideHttpClient(withXhr(), withInterceptorsFromDi()), provideHttpClientTesting()],
}).compileComponents();
}));

Expand Down
4 changes: 2 additions & 2 deletions src/app/app.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { HttpTestingController, provideHttpClientTesting } from '@angular/common/http/testing';
import { TestBed, getTestBed, waitForAsync } from '@angular/core/testing';

import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
import { provideHttpClient, withInterceptorsFromDi, withXhr } from '@angular/common/http';
import { API_URL, PULSE_DAYS } from 'config';
import { AppService } from './app.service';
import { PlayerType } from './utils/player.type';
Expand All @@ -15,7 +15,7 @@ describe('AppService', () => {
TestBed.configureTestingModule({
declarations: [],
imports: [],
providers: [provideHttpClient(withInterceptorsFromDi()), provideHttpClientTesting()],
providers: [provideHttpClient(withXhr(), withInterceptorsFromDi()), provideHttpClientTesting()],
}).compileComponents();

injector = getTestBed();
Expand Down
4 changes: 2 additions & 2 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { enableProdMode, provideZoneChangeDetection } from '@angular/core';

import { provideHttpClient } from '@angular/common/http';
import { provideHttpClient, withXhr } from '@angular/common/http';
import { bootstrapApplication } from '@angular/platform-browser';
import { AppComponent } from './app/app.component';
import { environment } from './environments/environment';
Expand All @@ -9,4 +9,4 @@ if (environment.production) {
enableProdMode();
}

bootstrapApplication(AppComponent, { providers: [provideZoneChangeDetection(),provideHttpClient()] }).catch((err) => console.error(err));
bootstrapApplication(AppComponent, { providers: [provideZoneChangeDetection(),provideHttpClient(withXhr())] }).catch((err) => console.error(err));
10 changes: 9 additions & 1 deletion tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,13 @@
"exclude": [
"src/test.ts",
"src/**/*.spec.ts"
]
],
"angularCompilerOptions": {
"extendedDiagnostics": {
"checks": {
"nullishCoalescingNotNullable": "suppress",
"optionalChainNotNullable": "suppress"
}
}
}
}
2 changes: 2 additions & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@
"compileOnSave": false,
"compilerOptions": {
"baseUrl": "./",
"ignoreDeprecations": "6.0",
"outDir": "./dist/out-tsc",
"sourceMap": true,
"esModuleInterop": true,
"declaration": false,
"experimentalDecorators": true,
"module": "es2020",
"moduleResolution": "bundler",
"strict": false,
"importHelpers": true,
"target": "ES2022",
"typeRoots": [
Expand Down
10 changes: 9 additions & 1 deletion tsconfig.spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,13 @@
"include": [
"src/**/*.spec.ts",
"src/**/*.d.ts"
]
],
"angularCompilerOptions": {
"extendedDiagnostics": {
"checks": {
"nullishCoalescingNotNullable": "suppress",
"optionalChainNotNullable": "suppress"
}
}
}
}
Loading