fix(litellm): close Token Spy client when worker is cancelled - #271
Merged
Conversation
ODSTokenSpyCallback._run() created an httpx.AsyncClient inside an async-with each time the worker task was (re)created. Under cancellation (LiteLLM model swap, gunicorn recycle, asyncio shutdown race) the __aexit__ could be skipped, leaking sockets and file descriptors that compounded with every restart. Create the client explicitly and close it in a finally block so aclose runs on both cancellation and normal exit.
# Conflicts: # ods/extensions/services/litellm/ods_token_spy_callback.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports upstream Osmantic#2642: fix(litellm): close Token Spy client when worker is cancelled
Original: Osmantic#2642
Retry pass: conflicted with an earlier port from this run; hunks were disjoint so both were unioned. Lint/structural/legacy-token checked.