chore(version): consolidate version to a single ods/VERSION source - #275
Merged
Conversation
Previously the version string was hardcoded in 9 separate locations (manifest.json x2, constants.sh, macos/constants.sh, constants.ps1, 06-directories.sh's fallback, dashboard-api main.py, ods-cli, ARCHITECTURE.md), kept in sync only by convention (comments saying 'must match constants.sh') and checked post-hoc by check-version-consistency.py. ods/VERSION is now the single file to edit. scripts/sync-version.sh regenerates every derived literal from it (each location stays a plain language-native literal — no new runtime cross-language coupling or container-mount risk). check-version-consistency.py now reads ods/VERSION as the canonical value instead of manifest.json, accepts an optional pre-release suffix (e.g. 2.6.1-exp) in its semver check, and skips the CHANGELOG.md parity requirement for suffixed/experimental builds (a real x.y.z release still requires a matching CHANGELOG entry, verified). Also brings ods-cli and ARCHITECTURE.md's version strings up to 2.6.1-exp, which were missed in the earlier bump (#274) — this repo's own consistency checker caught them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the 9 hardcoded version-string locations (manifest.json x2, constants.sh, macos/constants.sh, constants.ps1, 06-directories.sh fallback, dashboard-api main.py, ods-cli, ARCHITECTURE.md) into a single
ods/VERSIONfile.scripts/sync-version.shregenerates every derived literal from it — each location stays a plain language-native literal (no new runtime cross-language coupling or container-mount risk), matching this repo's existing convention of checked literals over dynamic reads.check-version-consistency.pynow readsods/VERSIONas canonical (was manifest.json), accepts an optional pre-release suffix in its semver check (needed for2.6.1-exp), and skips the CHANGELOG.md parity requirement only for suffixed/experimental builds — verified a real x.y.z bump still enforces it.Also fixes
ods-cliandARCHITECTURE.md, which were missed in the earlier 2.6.1-exp bump (#274) and would have failed this repo's own consistency checker.Verified:
scripts/sync-version.shround-trip tested (set+sync, restore),check-version-consistency.pypasses,make lintclean.