fix(dashboard): register core services on CPU hosts so Hermes card is clickable - #288
Merged
Merged
Conversation
… clickable The four core base-stack service manifests (llama-server, dashboard-api, dashboard, open-webui) declared `gpu_backends: [amd, nvidia]`. The dashboard-api manifest loader (config.py) skips any service whose gpu_backends omits the host backend and does not include "all". On a CPU install (GPU_BACKEND=cpu) all four core services were therefore dropped from SERVICES entirely — absent from /services and /api/status. Because calculate_feature_status() marks a required service "missing" unless it is present and healthy, every feature that requires a core service was gated to status "services_needed". The frontend maps that to `disabled` and renders a non-clickable <div>, so the Hermes Agent tile (requires dashboard-api + llama-server) showed but could not be clicked. Fix: set `gpu_backends: [all]` on the four core manifests, matching every bundled extension manifest and reflecting that these base-stack services run on all backends including CPU. Verified in-container: with [all] the loader registers all four core services under cpu/nvidia/apple; all four health endpoints return 200 from the dashboard-api container, so they report healthy and the Hermes feature becomes enabled/clickable (linking to hermes-proxy :9120, host resolved from window.location). Adds regression tests: real core manifests load under GPU_BACKEND=cpu, and a synthetic check documenting the backend filter (restrictive gpu_backends skipped, [all] kept). comfyui is intentionally left GPU-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the dashboard the Hermes Agent tile renders but is not clickable on a CPU install. Root cause traced live (
GPU_BACKEND=cpu, host10.1.1.17).The four core base-stack service manifests —
llama-server,dashboard-api,dashboard,open-webui— declaredgpu_backends: [amd, nvidia]. The dashboard-api manifest loader skips any service whosegpu_backendsomits the host backend and doesn't include"all"(config.pybackend filter). So onGPU_BACKEND=cpuall four core services were dropped fromSERVICESentirely — absent from/servicesand/api/status.calculate_feature_status()(routers/features.py) marks a required service "missing" unless it's present andhealthy. Withdashboard-api/llama-serverabsent, the Hermes feature (requires: [hermes, hermes-proxy, dashboard-api]+ any of[llama-server, litellm]) gotstatus: "services_needed", which the frontend maps todisabled→ a non-clickable<div>(Dashboard.jsx). Exactly the reported symptom.Fix
Set
gpu_backends: [all]on the four core manifests — matching every bundled extension manifest and reflecting that these base-stack services run on all backends including CPU.comfyuiis intentionally left GPU-only. Noconfig.pychange needed ("all"already short-circuits the filter;applehosts already bypass it).Evidence & verification (live on the box)
GET /servicesreturned 18 services with none of the four core ones;GET /api/features→hermes-agentservicesMissing: ["dashboard-api","llama-server"],status: "services_needed".ods-dashboard-apivia docker DNS, so once loaded they reporthealthy.load_extension_manifestsagainst the edited manifests: all four core services now register under cpu / nvidia / apple with no errors.window.location.hostname(serviceUrls.js), so the clickable tile resolves tohttp://<lan-ip>:9120/(magic-link gated by the proxy, by design).Tests
test_core_services_load_on_cpu_backend— loads the real service manifests underGPU_BACKEND=cpuand asserts the four core services register (guards against a core manifest reintroducing a backend-restrictive value).test_backend_filter_skips_restrictive_gpu_backends— documents the filter ([amd, nvidia]skipped on cpu,[all]kept).make lint✅;scripts/validate-manifests.sh✅ (27 compatible, 0 errors); test file byte-compiles.🤖 Generated with Claude Code