[NO-ISSUE] feat(guardrails): stronger code-standard + animation lint, fix broken gate#724
Closed
HerbertJulio wants to merge 2 commits into
Closed
[NO-ISSUE] feat(guardrails): stronger code-standard + animation lint, fix broken gate#724HerbertJulio wants to merge 2 commits into
HerbertJulio wants to merge 2 commits into
Conversation
…oken tokens.md links enforce-component-create.mjs called skillReferencedInTranscript (undefined; the function is pipelineReferencedInTranscript) → it threw and failed open, so the 'run the spec pipeline first' gate never blocked. Also repoint the dangling ./tokens.md links in no-invention/migration/ dependencies to the real catalog doc (.claude/docs/DESIGN.md § Animations).
… rules
validate-spec-compliance: block forbidden variant-prop names (variant/appearance/intent → kind),
is/has boolean prefixes, and camelCase (non-kebab) event names.
validate-tokens: block JS class presets (const *Classes = {}/[]/computed), component-local <style>
blocks, component-local @Keyframes, arbitrary animate-[…], and hardcoded duration/ease/delay-[…].
Both fire only on NEW matches (baseline diff) so existing components are grandfathered; verified
no false positives on button/input-text/badge and a clean sample.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthens the internal guardrails (
.claude/) so components follow the documented standards automatically, and fixes real bugs found while mapping coverage. Governance-only — separate from the toolkit code PR (#717) per.claude/rules/git-workflow.md.Fixes (B5)
enforce-component-create.mjscalledskillReferencedInTranscript(undefined; the function ispipelineReferencedInTranscript) → it threw and failed open, so the "run the spec pipeline first" gate never blocked. Repaired../tokens.mdlinks inno-invention.md/migration.md/dependencies.md→ repointed to the real catalog doc (.claude/docs/DESIGN.md § Animations).New enforcement (B1 + inline animations)
validate-spec-compliance: blocks forbidden variant-prop names (variant/appearance/intent→kind),is/hasboolean prefixes, and camelCase (non-kebab) event names.validate-tokens: blocks JS class presets (const *Classes = {}/[]/computed), component-local<style>blocks, component-local@keyframes, arbitraryanimate-[…], and hardcodedduration/ease/delay-[…].Both fire only on new matches (baseline diff), so existing components are grandfathered. Verified: no false positives on
button/input-text/badge; the bad-pattern sample blocks with exit 2; a clean sample passes.Not in this PR (follow-ups, noted)
/add-animationscaffold — depend ontokens.animationslanding in the catalog (in [NO-ISSUE] feat(webkit)!: adoption toolkit (in-package) + prop-vocabulary guardrails + canonical prop renames #717), so they follow that merge.DESIGN.mdanimation table intentionally left untouched.