feat(webkit): add CodeBlock border prop + show file type in Icons docs#752
Merged
Conversation
isaquebock
previously approved these changes
Jul 16, 2026
robsongajunior
previously approved these changes
Jul 16, 2026
HerbertJulio
previously approved these changes
Jul 16, 2026
robsongajunior
dismissed stale reviews from HerbertJulio and themself
via
July 16, 2026 19:23
0ec201c
robsongajunior
approved these changes
Jul 16, 2026
HerbertJulio
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
borderprop to thedata/code-blockcomponent and wires it through the spec, tests, and Storybook docs — mirroring the pattern used fordata/table.border?: boolean(defaulttrue) onCodeBlock, mirrored to adata-borderattribute withdata-[border]:Tailwind variants. On by default (preserves current appearance); set:border="false"to render the block flush inside a surface that already frames it. Non-breaking.h-[320px]tomax-h-[320px], so short snippets fit their content while taller ones still scroll at 320px..specs/code-block.md): newborderProps row, aBorderlessstory entry, updated height wording, recomputed checksum.data-borderpresent by default / absent when:border="false".borderargType + aBorderlessstory.CodeBlockhelper for the real@aziontech/webkit/code-block, and the Usage example now shows the HTML file type via afileName: 'index.html'filename bar.Notes
h-[320px]→max-h-[320px]change is behavioral, not an API break; existing long-code stories remain visually unchanged (still capped at 320px + scroll). Visual-regression snapshots may want a quick re-baseline.htmlis not in the code-block language→icon map, soindex.htmlshows the genericpi pi-fileicon; a dedicated code icon can be added in a follow-up if desired.