Make data processing thread safe#53
Open
mheinzler wants to merge 1 commit intoaziz:masterfrom
Open
Conversation
In some rare cases it can happen that on_data is called from different threads at the same time which then messes up the calculation of the regions to color. A thread lock in on_data and on_finished resolves this.
Collaborator
|
Disclaimer: I am not using the I make this disclaimer just because it looks like I am the only active maintainer in the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using this plugin to colorize gcc output and sometimes it happens that the color in the output is displaced because new data is being processed at the same time:
A thread lock on the data fixed that for me.