Fix race condition leading to AttributeError#70
Open
giampaolo wants to merge 1 commit intoaziz:masterfrom
Open
Fix race condition leading to AttributeError#70giampaolo wants to merge 1 commit intoaziz:masterfrom
giampaolo wants to merge 1 commit intoaziz:masterfrom
Conversation
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @aziz.
I've seen this error multiple times over the months (years?), without ever being able to come up with a reproducing test case. It just shows up from time to time. Long story short: these 2 lines check whether
window is not None:https://github.com/aziz/SublimeANSI/blob/master/ansi.py#L373-L374.
Window may not be None at line 373, but it can turn to None at lines 375 and 377 (this is the race condition). The error that can be seen in ST console is: