Open
Conversation
Owner
|
Nice work. I want to think a bit about the interface changes necessary for repeated values. For backward compatibility, get_value() should return the element value for no repetitions and the formatted element list including the separator for repeats. I'd like a get_values() method that returns a tuple(string). Elements with no repetitions would just have a single element tuple. |
Author
|
Sure, I can take a look at that. |
Author
|
Get_value was already backwards compatible. Added the get_values_list method. Named it that way for clarity and it returns a list instead of a tuple because we're building a list anyway, but can convert it to a tuple at the end if you'd prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see title
fixes #6