Skip to content

Improve edge spacer calculation to not overlap with nested nodes. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azriel91 merged 33 commits into from
May 11, 2026
Merged

Improve edge spacer calculation to not overlap with nested nodes. #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
8b23268
Add `node_rank` field to `SvgNodeInfo`.
azriel91 Apr 28, 2026
6d64ced
Deduplicate spacer absolute coordinates calculation.
azriel91 Apr 28, 2026
81d180e
Extract `NodeNestingInfos` calculation and store it on `IrDiagram`.
azriel91 Apr 28, 2026
ecd00ff
Replace for loops with iterators in `EdgeSpacerBuilder`.
azriel91 Apr 29, 2026
3d438db
Add `EdgeIdGenerator` to deduplicate logic.
azriel91 Apr 29, 2026
d8769d1
Use better names in `EdgeSpacerBuilder::build_cross_container_spacers…
azriel91 Apr 29, 2026
eb54133
Rename and reorder variables in `EdgeSpacerBuilder`.
azriel91 Apr 29, 2026
3e83678
Extract `EdgeSpacerBuilder::build_cross_container_spacers_for_edge_de…
azriel91 May 2, 2026
6e92d12
Extract `EdgeSpacerBuildDecider` and `LcaDepthCalculator` for smaller…
azriel91 May 2, 2026
05010c3
Add some comments to `EdgeSpacerBuilder`.
azriel91 May 2, 2026
67364ef
First pass of calculating `NodeRanksNested` instead of flat `NodeRanks`.
azriel91 May 2, 2026
6c1d7cb
Use `NodeRanksNested` in `EdgeSpacerBuilder`.
azriel91 May 2, 2026
57e91b6
Fix typos.
azriel91 May 2, 2026
0935c70
Partial fix for edge protrusions.
azriel91 May 5, 2026
6fb4cb5
For nodes with edge cycles, protrude edges from the "side" faces inst…
azriel91 May 6, 2026
a15b231
Include edges that are for nodes in a cycle, as part of the edge prot…
azriel91 May 6, 2026
d39f7a8
Edges as part of a cycle of nodes have different protrusions.
azriel91 May 7, 2026
a767fda
Don't curve edges outward if nodes to connect are adjacent siblings.
azriel91 May 7, 2026
55ba1bf
Don't special case tags / processes in ignoring edge protrusion.
azriel91 May 7, 2026
51c3018
Group nodes into things, tags, and processes for protrusion / spacer …
azriel91 May 7, 2026
9e9933b
Edges between tags and processes also use cycle logic to avoid overla…
azriel91 May 8, 2026
3726326
Update dependency versions.
azriel91 May 8, 2026
83612dd
Use LCA `NodeRank` instead of local `NodeRank` to determine dependenc…
azriel91 May 8, 2026
6b290f9
First attempt at fixing ortho curve.
azriel91 May 8, 2026
2eb29a2
Slightly better fix for ortho edge bends.
azriel91 May 8, 2026
0f9ddd1
Only add one spacer per group of siblings with the same `NodeRank` to…
azriel91 May 8, 2026
fe9b61b
Ignore `to` endpoint path adjustment when an edge has a cross-contain…
azriel91 May 8, 2026
436bf3c
Update `CHANGELOG.md`.
azriel91 May 8, 2026
cfb50fc
Rename workspace_tests input diagram string constants.
azriel91 May 10, 2026
90b9fb1
Rename workspace_tests input diagram files and add nested x2 input di…
azriel91 May 11, 2026
6a03a1d
Partial correction to doubly-nested edge paths.
azriel91 May 11, 2026
cf51ca2
Hacky fix for Z/S bend overshoot.
azriel91 May 11, 2026
2f75a23
Address clippy lints.
azriel91 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
* Add focus outlines around nodes and edges. ([#27][#27])
* Update `stroke_style: dashed` to mean `dasharray:4`. ([#27][#27])
* Fix duplication of tailwind classes on edges. ([#28][#28])
* Fix edge path routing issues regarding cross-container edges, spacers, and nested `NodeRank`s. ([#29][#29])

[#26]: https://github.com/azriel91/disposition/pull/26
[#27]: https://github.com/azriel91/disposition/pull/27
[#28]: https://github.com/azriel91/disposition/pull/28
[#29]: https://github.com/azriel91/disposition/pull/29


## 0.1.0 (2026-04-11)
Expand Down
Loading
Loading