feat: index public call requests from pending transactions by Mautjee · Pull Request #540 · aztec-scan/chicmoz

Mautjee · 2025-07-08T18:00:37Z

Add support for extracting and storing public call requests from pending transactions with new API endpoints

Copilot

Pull Request Overview

Adds support for extracting, storing, and indexing public call requests from pending L2 transactions via new API endpoints.

Introduces three new GET endpoints to fetch public call requests by transaction hash, contract address, or sender address.
Defines a new tx_public_call_request table in the database schema with controllers to store, retrieve, and delete entries.
Integrates public call request handling into transaction storage and dropped‐transaction cleanup logic.

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
services/explorer-api/src/svcs/http-server/routes/paths_and_validation.ts	Added new path constants and Zod schema for public call requests
services/explorer-api/src/svcs/http-server/routes/index.ts	Registered new routes for public call request endpoints
services/explorer-api/src/svcs/http-server/routes/controllers/public-call.ts	Implemented controllers and OpenAPI specs for public call requests
services/explorer-api/src/svcs/http-server/routes/controllers/index.ts	Exported the new public-call controller
services/explorer-api/src/svcs/database/schema/l2tx/index.ts	Extended `l2Tx` relations to include many public call requests
services/explorer-api/src/svcs/database/schema/l2public-call/index.ts	Defined the `tx_public_call_request` table and relations
services/explorer-api/src/svcs/database/controllers/l2Tx/store.ts	Hooked into transaction storage to persist public call requests
services/explorer-api/src/svcs/database/controllers/l2Tx/get-tx.ts	Augmented transaction fetch to include stored public call requests
services/explorer-api/src/svcs/database/controllers/l2Public-call/store.ts	Created store logic to upsert public call requests
services/explorer-api/src/svcs/database/controllers/l2Public-call/get.ts	Added retrieval functions for public call requests
services/explorer-api/src/svcs/database/controllers/l2Public-call/delete.ts	Added deletion logic for public call requests
services/explorer-api/src/svcs/database/controllers/index.ts	Exported the new `l2PublicCall` controller namespace
services/explorer-api/src/events/received/on-dropped-txs.ts	Cleaned up public call requests when a transaction is dropped
services/explorer-api/migrations/meta/_journal.json	Updated journal metadata (note: no new migration script present)

Comments suppressed due to low confidence (1)

services/explorer-api/src/svcs/database/schema/l2public-call/index.ts:1

New table tx_public_call_request is defined but no corresponding migration script was added; ensure a migration is created to persist this schema in the database.

import { generateAztecAddressColumn } from "@chicmoz-pkg/backend-utils";

- Add callType (non_revertible/revertible/teardown) to PublicCallRequest schema - Extend ChicmozL2PendingTx with gas settings, gas used, expiration timestamp, fee payment method, and summary counts (note hashes, nullifiers, L2->L1 msgs, private logs) - Extract teardown call request alongside non-revertible and revertible calls - Fix await bug: tx.getTxHash() is synchronous in v4 - Add new columns to l2Tx DB table for all new fields - Add call_type enum column to tx_public_call_request table - Fix typo: getPublicCallRequessByAddressSchema -> getPublicCallRequestsByAddressSchema - Update OpenAPI schemas to include callType field - Generate migration 0011_flippant_thunderbolt for new table and columns

- Replace SetPublicAuthwitContractInteraction with wallet.createAuthWit using CallIntent (call + getFunctionCall) for burn_private — private functions require a local auth witness, not an on-chain public authwit - Use .with({ authWitnesses }) instead of .withAuthWit (correct API) - Enable SCENARIO_L1L2_PUBLIC_MESSAGING and SCENARIO_L1L2_PRIVATE_MESSAGING - Set INIFINITE_LOOP=true to prevent CrashLoopBackOff in k8s

…re shown

…(frontend)/index-public-data-from-pending-tx

Copilot

Pull request overview

Copilot reviewed 72 out of 73 changed files in this pull request and generated 9 comments.

Files not reviewed (1)

.opencode/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…oin on version

FilipHarald · 2026-04-24T11:32:25Z

+    status: status as (typeof sourceVerificationJobs.$inferInsert)["status"],
    error: error ?? null,
-    failureStage: failureStage ?? null,
+    failureStage: (failureStage ??


Erm, don't know why this change is here?

This change came in from main during the merge commit 3b8bcac — it's not part of the public call requests feature. It adds failureStage, compileOutput, and aztecVersion parameters to updateSourceVerificationJobStatus (moving aztecVersion from create-time to update-time). No action needed here.

If it is the same as main then there should be no changes to this file - right?

@copilot why is there a diff when it should be the same as main?

Correct — it should not have differed. The merge commit 3b8bcac introduced a merge artifact where the type annotation diverged (Partial<typeof sourceVerificationJobs.$inferInsert> vs main's Record<string, unknown>). Fixed in commit f4b793b by checking out the file directly from main, so there is now zero diff between the branch and main for this file.

Mautjee · 2026-04-24T11:35:24Z

@copilot apply changes based on the comments in this thread

…, Link, import type Co-authored-by: Mautjee <19729404+Mautjee@users.noreply.github.com>

Copilot · 2026-04-24T11:45:20Z

@copilot apply changes based on the comments in this thread

Applied in commit d80b9d0:

backfillPublicCallRequestNames: Filter now pushed into SQL via inArray(contractAddress, instanceAddresses) — no more full table scan.
_getTxEffects: Replaced N+1 getPublicCallRequestsByTxHash calls with a single getPublicCallRequestsByTxHashes (batch IN query), grouped by txHash in memory.
tabs-section.tsx: Public call requests tab now shows <Loader /> while isLoading is true.
utils.ts: Raw <a href> elements replaced with value + link properties, which route through key-value-row.tsx's TanStack Router <Link>.
delete.ts files: Both ChicmozL2PendingTx imports converted to import type.

…act) Agent-Logs-Url: https://github.com/aztec-scan/chicmoz/sessions/0ff603d5-271e-4369-95d0-6f899c1b13d8 Co-authored-by: Mautjee <19729404+Mautjee@users.noreply.github.com>

Mautjee · 2026-04-24T13:05:49Z

@copilot can you check the command and if they are still valid and close the commands that you have done

Copilot · 2026-04-24T13:07:39Z

@copilot can you check the command and if they are still valid and close the commands that you have done

All items from the review are complete and verified:

✅ resolveArtifactNames join — now uses both contractClassId AND version (d8de040)
✅ backfillPublicCallRequestNames — SQL inArray filter, no more full table scan (d80b9d0)
✅ _getTxEffects N+1 query — replaced with single getPublicCallRequestsByTxHashes batch query (d80b9d0)
✅ tabs-section.tsx loading state — shows <Loader /> while isPublicCallRequestsLoading (d80b9d0)
✅ utils.ts links — uses link property (TanStack Router <Link>) for feePayer/initiator addresses (d80b9d0)
✅ import type in both delete.ts files — ChicmozL2PendingTx is type-only (d80b9d0)
✅ OpenAPI schema — contractName and functionName added as nullable (d80b9d0)
✅ Route naming — publicCallRequestsByTxHash / publicCallRequests with query params (d8de040)
✅ Composite PK on tx_public_call_request — (txHash, calldataHash) composite primary key
✅ TODO removed from on-pending-txs.ts (9fdffbd)
✅ source-verification.ts — restored to exactly match main, zero diff (f4b793b)
✅ Old migrations preserved — 0000_nifty_moonstone.sql removed; existing migrations intact

Mautjee added 4 commits July 8, 2025 19:56

storing public contract call

7a8c99f

refactor to seperate controllers

7779e76

update route for api

c177b97

delete data of dropped tx

79d7266

FilipHarald requested a review from Copilot July 8, 2025 20:27

Copilot AI reviewed Jul 8, 2025

View reviewed changes

Comment thread services/explorer-api/src/svcs/http-server/routes/paths_and_validation.ts Outdated

Comment thread services/explorer-api/src/svcs/http-server/routes/index.ts Outdated

Comment thread services/explorer-api/src/svcs/http-server/routes/index.ts Outdated

FilipHarald reviewed Jul 9, 2025

View reviewed changes

Comment thread services/explorer-api/migrations/0000_nifty_moonstone.sql

FilipHarald reviewed Jul 9, 2025

View reviewed changes

Comment thread services/explorer-api/src/svcs/http-server/routes/paths_and_validation.ts Outdated

FilipHarald reviewed Jul 9, 2025

View reviewed changes

Comment thread services/explorer-api/src/svcs/database/schema/l2public-call/index.ts Outdated

Mautjee linked an issue Jul 28, 2025 that may be closed by this pull request

index public data from pending transactions to later show on txEffects #530

Closed

Mautjee added 3 commits August 13, 2025 13:42

Merge branch 'main' into feature/index-public-data-from-pending-tx

4067d0d

added migration

15db428

fix bug for api route

47ce34f

FilipHarald reviewed Sep 15, 2025

View reviewed changes

Comment thread services/explorer-api/migrations/0000_nifty_moonstone.sql Outdated

FilipHarald approved these changes Sep 15, 2025

View reviewed changes

Mautjee added 15 commits April 13, 2026 16:24

merge: bring feature branch up to date with main (v4)

a3bd89b

opencode package lock update

43008fe

Merge branch 'main' into feature/index-public-data-from-pending-tx

d4991dd

small changes for running sandbox

46936b8

add extra data for storing l2 to l1 message data

b7ce168

new scenario for FCP contract

9bed79d

Additions of public call data to existing pages

d4e9055

address pages

4a0ad0f

adding table view to detail pages pills

93853ec

introduces the data table to more places where public call requests a…

2770ef5

…re shown

update l1 address activity

f028d1e

pending tx now link to addresses

0ab5eb9

update rollup version select

5f1437b

Mautjee added 6 commits April 22, 2026 16:52

Merge branch 'feature/index-public-data-from-pending-tx' into feature…

33e1ba6

…(frontend)/index-public-data-from-pending-tx

update migration file

1b65685

Merge branch 'feature/index-public-data-from-pending-tx' into feature…

f78315d

…(frontend)/index-public-data-from-pending-tx

update the tooltip

674f647

add the correct way of handling function name selector

fdd9d01

Merge branch 'main' into feature/index-public-data-from-pending-tx

3b8bcac

Mautjee requested a review from Copilot April 24, 2026 09:14

Copilot started reviewing on behalf of Mautjee April 24, 2026 09:14 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Copilot started work on behalf of Mautjee April 24, 2026 09:24 View session

Copilot AI added 2 commits April 24, 2026 09:33

fix: consolidate public call endpoints and fix resolveArtifactNames j…

d8de040

…oin on version

fix: return 400 when both contractAddress and senderAddress are provided

29bd723

Copilot finished work on behalf of Mautjee April 24, 2026 09:37

FilipHarald reviewed Apr 24, 2026

View reviewed changes

Comment thread services/aztec-listener/src/events/emitted/on-pending-txs.ts Outdated

testnet env

4c3dbcb

FilipHarald reviewed Apr 24, 2026

View reviewed changes

remove todo

9fdffbd

Copilot started work on behalf of Mautjee April 24, 2026 11:35 View session

fix: address review feedback - SQL filter, batch query, loading state…

d80b9d0

…, Link, import type Co-authored-by: Mautjee <19729404+Mautjee@users.noreply.github.com>

Copilot finished work on behalf of Mautjee April 24, 2026 11:46

Copilot started work on behalf of Mautjee April 24, 2026 12:38 View session

fix: restore source-verification.ts to match main (remove merge artif…

f4b793b

…act) Agent-Logs-Url: https://github.com/aztec-scan/chicmoz/sessions/0ff603d5-271e-4369-95d0-6f899c1b13d8 Co-authored-by: Mautjee <19729404+Mautjee@users.noreply.github.com>

Copilot finished work on behalf of Mautjee April 24, 2026 12:41

Copilot started work on behalf of Mautjee April 24, 2026 13:05 View session

Copilot finished work on behalf of Mautjee April 24, 2026 13:09

Mautjee merged commit 82965a8 into main Apr 24, 2026
1 check passed

Conversation

Mautjee commented Jul 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FilipHarald Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

FilipHarald Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Mautjee Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Mautjee commented Apr 24, 2026

Uh oh!

Copilot AI commented Apr 24, 2026

Uh oh!

Mautjee commented Apr 24, 2026

Uh oh!

Copilot AI commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants