Disable cgo: allow execution on machines without glibc (alpine and openwrt use musl-libc)#537
Open
madejackson wants to merge 17 commits intoazukaar:unstablefrom
Open
Disable cgo: allow execution on machines without glibc (alpine and openwrt use musl-libc)#537madejackson wants to merge 17 commits intoazukaar:unstablefrom
madejackson wants to merge 17 commits intoazukaar:unstablefrom
Conversation
now also works on systems with musl-libc, which is predominantly alpine and openwrt
now also works on systems with musl-libc, which is predominantly alpine and openwrt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a go build issue where the final binary made use of a shared glibc library on x86_64. This lead to an issue where the binary could not be run on a machine without glibc (alpine and openwrt use musl-libc).
This commits add CGO_ENABLED=0 in front of go build commands to force go build to only use go libraries. This avoids this issue altogether while having a more predictable outcome.
There are two commits. The first commit disables cgo only where I encountered the error.
The second commit disables cgo for every go build command.