Skip to content

Setup CI#8

Merged
Ritunjai-Sharma merged 16 commits into
mainfrom
feature/investigate_CI
Mar 20, 2026
Merged

Setup CI#8
Ritunjai-Sharma merged 16 commits into
mainfrom
feature/investigate_CI

Conversation

@Ritunjai-Sharma

@Ritunjai-Sharma Ritunjai-Sharma commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

PR for setting up CI + checks.
Associated Issue: #9

The following work was done in this PR:

  • The CI had been automatically disabled due to inactivity in the repo for an extended period of time. This has now been turned back on, meaning CI checks now fire when pushing code to a branch
  • PRs had no guardrails meaning anyone could merge a PR into main without PR approval. This has now been fixed by updating the settings here.
  • The CI configuration, i.e., python-package.yml has been updated to follow tubular's configuration
  • Spelling mistakes in the repo have been fixed using codespell
  • Switched to prek for running pre-commit checks like tubular
  • Removed some stale references to tubular in the repo

Notes for the reviewer:

  • As part of updating python-package.yml to match current setup of tubular, I tried using uv pip install .[dev] like here. However, this was causing matrix testing specifically for python 3.10 (all other python versions passed the tests) to fail due to some SHAP related errors. Here's the failing build for reference. Therefore, I haven't made this change for now. Let me know if this change is needed and if so, can create an issue on the board to investigate it in depth.

@Ritunjai-Sharma Ritunjai-Sharma changed the title Dummy PR Setup CI Mar 3, 2026
Comment thread .devcontainer/devcontainer.json
Comment thread .devcontainer/devcontainer.json Outdated
Comment thread model_interpreter/interpreter.py
Comment thread requirements-dev.txt
…vcontainer and updated devcontainer to use uv for env creation

@adamsardar adamsardar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. All looks good!

@Ritunjai-Sharma Ritunjai-Sharma merged commit c0bbfd0 into main Mar 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants