Complete README and clean up extension - #5
Merged
Conversation
Editors sometimes need a header that is visually styled but must not appear in the document heading outline, for example a large intro line that should stay a plain paragraph for accessibility and SEO. Adds the values 7 (p) and 8 (span) to both the header type and the subheader type field. The matching labels already existed in the language file and are now actually used.
Fixes the invalid file date (an impossible "+13:13" timezone offset), adds the standard XLIFF file attributes and aligns the indentation and ordering of the trans-units.
The README only contained a credits note and did not explain what the extension does or that it is backend-only: without a template override in the site package nothing is rendered in the frontend. Rewrites it following the structure of our other b13 extension READMEs (container, picture) with features, rationale, installation, a field reference and a Fluid rendering example.
Adds the PHP requirement, authors, support links, keywords and package sorting to composer.json and excludes development files from the distribution archive via .gitattributes.
Adds a lightweight CI pipeline that validates composer.json, lints all PHP files against PHP 8.1 to 8.3 and validates the XLIFF files, so the status badge in the README reflects a real workflow.
achimfritz
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive review and clean-up of EXT:headertypes plus a full README rewrite in b13 style (aligned with
container/picture).Changes
p(7) andspan(8) as header type options for header and subheader — for headings that must be styled but stay out of the document outline (accessibility/SEO). The matching language labels already existed and are now used.+13:13date, standard attributes, consistent indentation/order).phprequirement, authors, support links, keywords, package sorting) and a.gitattributesfor the distribution archive.Notes / open points
header_layoutfield relies on an exactstr_replaceof the Core showitem string. Stable across v12–v14 today, but a potential breaking point on future Core changes — left as-is for now.p/spanaddition is a feature; a1.3.0release would be appropriate when merging.Locally verified:
php -l,composer validate --strict,xmllintall pass.