Export TaskState and RunState enums from extension module#34
Merged
Conversation
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Export task enums from Rust extension module
Export TaskState and RunState enums from extension module
Feb 2, 2026
bcho
requested changes
Feb 2, 2026
Member
bcho
left a comment
There was a problem hiding this comment.
update existing code references to state string to use enum
Replace string literals with typed enums throughout the codebase: - checkpoint.rs: Parse task state and use TaskState::Cancelled - event.rs: Parse task/run states and use TaskState::Cancelled, RunState::Running - run.rs: Use TaskState and RunState enums for state management and comparisons - claim.rs: Use TaskState and RunState enums for state management State values are read from database as strings, parsed into enums for type-safe comparisons, and converted back to strings when writing to database. Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
Contributor
Author
Done in commit 88b66ba. Updated checkpoint.rs, event.rs, run.rs, and claim.rs to use TaskState and RunState enums instead of string literals for type-safe state handling. State values are read from the database as strings, parsed into enums for comparisons, and converted back to strings when writing to the database. |
Replace catch-all patterns with explicit exhaustive matches that use unreachable!() for impossible states. This makes the code more explicit about which states can occur and improves compile-time checking. Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
bcho
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension module had no public types for representing task and run states, forcing consumers to use string literals.
Changes
New
typesmodule withTaskStateandRunStateenumsPending,Running,Sleeping,Completed,Failed,CancelledDisplay(enum → "lowercase") andFromStr(parse with validation)Public exports at crate root:
absurd::{TaskState, RunState}Internal code updates to use enums instead of string literals
checkpoint.rs,event.rs,run.rs, andclaim.rsto parse state strings from database into enums for type-safe comparisonsunreachable!()for impossible statesUsage
Enables type-safe state handling in consuming crates and internally within the extension, while maintaining string compatibility with the database layer.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.