Constant node fusion - #1067
Merged
Merged
Conversation
The existing fold tested the analyzed child with utils/constant?, which answers for raw values. On CLJS and cljd analyze returns constants unwrapped and the test worked; on the JVM it wraps them in ConstantNode, so the fold never happened there. cond's :else clause expands to (if :else expr nil), so every cond paid a runtime truthiness test. const-node? also covers values that analyze returns unwrapped on the JVM (a class, a symbol, a constant collection), which self-evaluate through the Object impl of Eval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.