[babel 8] Require Node.js ^18.20.0 || ^20.10.0 || >=21.0.0#16457
Merged
JLHwung merged 3 commits intobabel:mainfrom Apr 30, 2024
Merged
[babel 8] Require Node.js ^18.20.0 || ^20.10.0 || >=21.0.0#16457JLHwung merged 3 commits intobabel:mainfrom
^18.20.0 || ^20.10.0 || >=21.0.0#16457JLHwung merged 3 commits intobabel:mainfrom
Conversation
JLHwung
added
PR: Breaking Change 💥
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56793 |
Member
|
Let's do 18.20 which supports import attributes 🙏 |
JLHwung
changed the title
^18.18.0 || >=20.0.0^18.20.0 || >=20.0.0
JLHwung
force-pushed
the
babel-8-node-18
branch
from
0c4a6e4 to
ee807c7
Compare
JLHwung
changed the title
^18.20.0 || >=20.0.0^18.20.0 || ^20.10.0 || >=21.0.0
nicolo-ribaudo
approved these changes
Apr 30, 2024
Member
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Node.js 18 reaches end of life today, but I think it's good to still support it for the time being.
Contributor
Author
|
(🤫We are still in 2024) Node.js 18 will reach EOL on 2025-04-30. |
existentialism
approved these changes
Apr 30, 2024
liuxingbaoyu
approved these changes
Apr 30, 2024
Member
liuxingbaoyu
left a comment
liuxingbaoyu
left a comment
There was a problem hiding this comment.
Although I personally like ^14, it's fine for now.
Member
|
@liuxingbaoyu When we dropped 14 the motivation against dropping it was that a serious memory leak (jestjs/jest#11956 (comment)) was preventing people from upgrading to Node.js 16+. However, that bug has then been fixed in Node.js 20 (nodejs/node#49950) and backported to 18 (nodejs/node#51004). |
github-actions
bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we drop Node.js 16 support for Babel 8. Node.js 16 has reached end-of-life on Sept. 11th 2023. The Node.js 18 requirement is also bumped to 18.20.0, which supports
fs.readdir(... { recursive: true }), the--importnode flag, the esm equivalent of--requireand the import attributes. The first feature will be used in babel-cli and the second one may potentially benefit babel-node.The Node.js 20 requirement is also bumped to 20.10.0 for import attributes support.
For references here are node requirements of other popular tools, we are not the first one to drop Node.js 16 so it should probably be fine.
eslint:
^18.18.0 || ^20.9.0 || >=21.1.0jest
^16.10.0 || ^18.12.0 || >=20.0.0prettier
>= 18typescript-eslint
^18.18.0 || >=20.0.0