feat(auth): add CLIENT_REGISTRATION_TTL=0 never-expire opt-in#38
Merged
Conversation
Sealed client_id expiry (default 7d) permanently breaks MCP clients
that never re-run dynamic client registration on invalid_client (e.g.
Azure APIM connectors), which loop on the 400 indefinitely. Setting
CLIENT_REGISTRATION_TTL=0 disables expiry (emits client_id_expires_at=0)
as an opt-in escape hatch; the default and the 90d cap are unchanged.
Also surface client_id validation rejections at /authorize and /token
via mcp_auth_access_denied_total{reason} and access_denied_* WARN logs,
so a stuck client is visible beyond raw 4xx access logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sealed client_id expiry (default 7d) permanently breaks MCP clients that never re-run dynamic client registration on invalid_client (e.g. Azure APIM connectors), which loop on the 400 indefinitely. Setting CLIENT_REGISTRATION_TTL=0 disables expiry (emits client_id_expires_at=0) as an opt-in escape hatch; the default and the 90d cap are unchanged.
Also surface client_id validation rejections at /authorize and /token via mcp_auth_access_denied_total{reason} and access_denied_* WARN logs, so a stuck client is visible beyond raw 4xx access logs.