Skip to content

fix: uses appropriate typings for property read/write request payloads #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertsLando merged 1 commit into from
May 7, 2026
Merged

fix: uses appropriate typings for property read/write request payloads #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions src/lib/EventTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ import {
BACNetObjectID,
BACNetPropertyID,
BACNetAppData,
WritePropertyRequest,
ReadPropertyRequest,
} from './types'

export type Constructor<T = object> = new (...args: any[]) => T
Expand Down Expand Up @@ -74,22 +76,12 @@ export interface BaseEventContent {

// These more specific interfaces help TypeScript provide better IntelliSense
export interface ReadPropertyContent extends BaseEventContent {
payload: {
objectId: BACNetObjectID
property: BACNetPropertyID
}
payload: ReadPropertyRequest
address?: string
}

export interface WritePropertyContent extends BaseEventContent {
payload: {
objectId: BACNetObjectID
property?: BACNetPropertyID
value?: {
property?: BACNetPropertyID
value?: BACNetAppData | BACNetAppData[]
}
}
payload: WritePropertyRequest
}

export interface ReadPropertyMultipleContent extends BaseEventContent {
Expand Down
Loading