Lesson 1.2 - #4
Open
badgerbadgers wants to merge 2 commits into
Open
Conversation
resubmitting code for lesson 1.2.
esthicodes
reviewed
Mar 20, 2022
esthicodes
left a comment
There was a problem hiding this comment.
Nice Change:)
Did you solve the major issues with github workflow and successfully create conflicts with your local environment?
These are some uses in working environment, benefits as you requested :)
- Less boilerplate code to handle parameters
- Anyone reading your code immediately sees which parameters are optional, without having the function body read (where they might or might not be on top of the function).
- You can change a function to have default parameters instead of removing a parameter altogether to keep better backward-compatibility, thus can be helpful when refactoring.
Owner
Author
|
Yes I'm still getting used to how branches and merging work in github. I had deleted my local branch 'lesson-1-2" so I merged the submitted pull request then resubmitted my 'lesson-1-2' branch with the spacing changes. I was getting an error in terminal when I created a new branch for lesson 1-3. The checkout branch -lesson-1-3 would not execute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmitting code for lesson 1.2