Skip to content

Lesson 1.2 - #4

Open
badgerbadgers wants to merge 2 commits into
mainfrom
lesson-1-2
Open

Lesson 1.2#4
badgerbadgers wants to merge 2 commits into
mainfrom
lesson-1-2

Conversation

@badgerbadgers

Copy link
Copy Markdown
Owner

Resubmitting code for lesson 1.2

resubmitting code for lesson 1.2.

@esthicodes esthicodes left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Change:)
Did you solve the major issues with github workflow and successfully create conflicts with your local environment?
These are some uses in working environment, benefits as you requested :)

  • Less boilerplate code to handle parameters
  • Anyone reading your code immediately sees which parameters are optional, without having the function body read (where they might or might not be on top of the function).
  • You can change a function to have default parameters instead of removing a parameter altogether to keep better backward-compatibility, thus can be helpful when refactoring.

@badgerbadgers

Copy link
Copy Markdown
Owner Author

Yes I'm still getting used to how branches and merging work in github. I had deleted my local branch 'lesson-1-2" so I merged the submitted pull request then resubmitted my 'lesson-1-2' branch with the spacing changes. I was getting an error in terminal when I created a new branch for lesson 1-3. The checkout branch -lesson-1-3 would not execute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants