fix: prevent npm install failure during production installs#10
Open
amitkot wants to merge 2 commits into
Open
Conversation
fix: make husky prepare script non-breaking during production install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
npm install --omit=devfails because thepreparescript attempts to executehusky, which is not present in productionenvironments.
Details
In
package.json, thepreparescript is currently set tohusky. When installing only production dependencies,huskyis not installed, leading to a "commandnot found" error and halting the installation process.
Changing the script to
husky || trueallows the installation to succeed in environments wherehuskyis not required.Impact
npm install --omit=devin production/CI environments.