fix: make husky prepare script non-fatal on install#12
Open
zipus wants to merge 1 commit into
Open
Conversation
The prepare lifecycle script runs husky, a devDependency. Consumers install with --omit=dev (e.g. pi install), so husky is absent but npm still runs prepare, failing with code 127. Appending '|| true' lets installs succeed while contributors with husky installed still get hooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
preparelifecycle script sonpm install --omit=dev(used bypi install) no longer fails.The
preparescript runshusky— adevDependency. When consumers install without dev deps, husky is absent but npm still runsprepare, aborting withcode 127:Change
Contributors who install dev deps still get git hooks; consumers no longer hit a fatal error.
Closes #11