Conversation
Collaborator
Author
|
Fixing the party filter order now. |
rthor
commented
Oct 24, 2016
| * @param {Array} mps | ||
| * @returns {{byName: Array.<T>, byParty: Array.<T>}} | ||
| */ | ||
| function createMpPartition(mps) { |
Collaborator
Author
There was a problem hiding this comment.
can this mps ever be falsy?
Collaborator
Author
|
A key, that comprises the party name and the name of the person is now responsible for the sort order. Also, I cleaned the component up a bit. Hope that's OK :) |
Collaborator
Author
|
|
Collaborator
Author
|
Should I close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.